Fix broken external links found with automated link checking#424
Fix broken external links found with automated link checking#424Copilot wants to merge 5 commits intocopilot/update-workflow-file-feedbackfrom
Conversation
|
@copilot this PR will merge after #426. Change the base branch and re-evaluate your changes, as some of the changes (eg: "Converted 30+ internal documentation links from .md to .html extension") do not align with how docfx works. Additionally, when the workflow is run in the context of a PR, include a table of newly-broken links as a single comment on that PR that is updated on subsequent runs. Issues should only be created if the context was NOT a PR |
Addressed in cf944da:
I can't change the base branch myself, but I see you've already done that. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
TimHess
left a comment
There was a problem hiding this comment.
@copilot update the check-links workflow to filter out links from the files in /docs/api. Read the output from the workflow in #424 (comment) and fix as many of those redirects as you can. Also check if there's an easy way to handle rate limiting and implement it if there is.
Done in 04a608b:
|
|
Done in 1b19072. Summary of changes: Workflow:
Broadcom links:
Samples:
Microsoft links:
Regarding redirect filtering: The |
Co-authored-by: Cursor <cursoragent@cursor.com>
External link checking results
Errors per inputErrors in docs/docs/v2/connectors/mysql.md
Errors in docs/docs/v3/connectors/mysql.md
Errors in docs/docs/v4/connectors/mysql.md
|
b2a8e9f to
1d336d8
Compare
1d336d8 to
0570e87
Compare
0570e87 to
30baab7
Compare
30baab7 to
18ceece
Compare
docs/docs/v4/connectors/cosmosdb.md
Outdated
| ### Configure connection string | ||
|
|
||
| The CosmosDB connection string can be obtained as described in the [Microsoft documentation](https://learn.microsoft.com/azure/cosmos-db/nosql/how-to-dotnet-get-started#retrieve-your-account-connection-string). | ||
| The CosmosDB connection string can be obtained as described in the [Microsoft documentation](https://learn.microsoft.com/azure/cosmos-db/how-to-dotnet-get-started). <!-- TODO: what page describes how to get connection strings now? not this one --> |
There was a problem hiding this comment.
@bart-vmware this one is tricky, I looked for a couple minutes, but it seems like they removed this approach for CosmosDb from the docs?
There was a problem hiding this comment.
Yeah, the connection string parameters are mysteriously undocumented by Microsoft. The closest I could find is https://learn.microsoft.com/azure/service-connector/how-to-integrate-cosmos-sql#other-client-types-2. I think the replacement link should be: https://learn.microsoft.com/azure/static-web-apps/database-azure-cosmos-db#get-database-connection-string-for-local-development.
18ceece to
4563611
Compare
- external links to - CredHub API, Spring AMQP, and Spring Cloud projects - Broadcom/Pivotal/samples/Microsoft - CredHub/Samples/CircuitBreaker links - Reduce external redirects - Fix double 'the' in fileshares usage docs - Disambiguate Redis/Valkey versions, clarify Thinktecture reference - Fix 'n0t' typo in v3 fileshares docs - TAS SSO→Single Sign-On Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- redirect reductions for docs.microsoft.com and trailing slashes - remove /en-US/ from mozilla links
ec65dd2 to
b3cce71
Compare
Addresses broken external URLs across the documentation.
Broken link fixes (~150 files)
docs.pivotal.ioanddocs.vmware.comlinks updated to currenttechdocs.broadcom.compaths for Spring Cloud Services → Application Services, SSO, CredHub, MySQL, Postgres, RabbitMQ, Redis/Valkey, GemFire Native Client, Metric Registrar, Volume Services, CSB (AWS/Azure/GCP), Apps Managerdocs.microsoft.com→learn.microsoft.com,docs.asp.net→learn.microsoft.com,visualstudio.com→visualstudio.microsoft.com; reduced redirects where possible without forcing localizationprojects.spring.io/spring-cloud→spring.io/projects/spring-cloud-*; trailing slash fixesspring-cloud-samples/hystrix-dashboard→Netflix-Skunkworks/hystrix-dashboard,cf-platform-eng/mssql-server-broker→cloudfoundry-attic/mssql-server-broker,cloudfoundry-incubator→cloudfoundrycredhub-api.cfapps.io→docs.cloudfoundry.org/api/credhub/version/main/with corrected anchors (#_overwriting_credential_values,#_permissions)pivotal.io/platform-acceleration-lablinks removedtanzu.vmware.com/gemfire→vmware.com/products/...,tanzu.vmware.com/observability→broadcom.com/products/...,hhttpstypo,start.steeltoe.io/api/config/→/api/uiconfig/Also fixes root-relative markdown links that docfx does not see (inadvertently broken in #363)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.