ci: remove unused API keys from CI workflow #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove STACKONE_API_KEY and OPENAI_API_KEY environment variables from CI workflow as they are not used in tests: - STACKONE_API_KEY is only used in a skipped integration test - OPENAI_API_KEY is not used in any tests
ryoppippi
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused API key environment variables (STACKONE_API_KEY and OPENAI_API_KEY) from the CI workflow configuration. These credentials are not required for running the test suite since the only test that references STACKONE_API_KEY is skipped, and OPENAI_API_KEY is only used in example code, not tests.
Key Changes:
- Removed
STACKONE_API_KEYandOPENAI_API_KEYfrom thecijob environment configuration - Removed
STACKONE_API_KEYandOPENAI_API_KEYfrom thecoveragejob environment configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused API key environment variables from CI workflow.
Changes
STACKONE_API_KEYandOPENAI_API_KEYenvironment variables fromciandcoveragejobsReason
These environment variables are not actually used in tests:
STACKONE_API_KEY: Only referenced in a skipped integration test (test_live_feedback_submission)OPENAI_API_KEY: Not used in any tests (only in examples)Testing
Summary by cubic
Removed unused STACKONE_API_KEY and OPENAI_API_KEY from the CI and coverage jobs to reduce secret exposure and simplify the workflow. Tests don’t use these keys (STACKONE only in a skipped integration test; OPENAI only in examples).
Written for commit 214db5a. Summary will update on new commits.