Skip to content

chore: fix typos ignore regex #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryoppippi wants to merge 1 commit into from
Closed

chore: fix typos ignore regex #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[default]
locale = 'en-us'
extend-ignore-re = [
"(?s)(#|//)\\s*spellchecker:off.*?\\n\\s*(#|//)\\s*spellchecker:on",
"(?s)<!--\\s*spellchecker:off.*?\\n\\s*spellchecker:on\\s*-->",
"(?s)(#|//)\\s*spellchecker:off[\\s\\S]*?(#|//)\\s*spellchecker:on",
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated regex pattern removes the newline requirement and whitespace matching before the second comment marker. This could cause the pattern to match unintended content. For example, it could match cases where "spellchecker:on" appears in the middle of a line without a proper comment marker prefix.

The pattern should probably be:
"(?s)(#|//)\\s*spellchecker:off[\\s\\S]*?\\s*(#|//)\\s*spellchecker:on"

This ensures that whitespace is matched before the second comment marker, making the pattern more robust.

Suggested change
"(?s)(#|//)\\s*spellchecker:off[\\s\\S]*?(#|//)\\s*spellchecker:on",
"(?s)(#|//)\\s*spellchecker:off[\\s\\S]*?\\s*(#|//)\\s*spellchecker:on",

Copilot uses AI. Check for mistakes.
"(?s)<!--\\s*spellchecker:off\\s*-->[\\s\\S]*?<!--\\s*spellchecker:on\\s*-->",
"(?Rm)^.*#\\s*spellchecker:disable-line$",
"(?m)^.*<!--\\s*spellchecker:disable-line\\s*-->\\n.*$"
"(?m)^.*<!--\\s*spellchecker:disable-line\\s*-->\\n.*$",
]

[files]
Expand Down
Loading