fix(tickets): scroll viewport on cmd+up/down jump#117
Merged
Conversation
The Tickets list watched outcomeSelectedIndex and scrolled to a separately-captured selectedRowID that lagged one keypress behind — so cmd+up/down moved the selection but not the viewport until the next arrow press. Watch selectedRowID directly and scroll to the id onChange delivers, mirroring the Sessions tab. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Tickets tab, ⌘↑/↓ (jump to first/last row) moved the selection highlight but not the scroll viewport — the pane only caught up on the next regular ↑/↓ press.
Root cause
The scroll was driven by:
It watched the raw index and scrolled to a separately-derived
selectedRowIDcaptured from the body, which lagged one keypress behind the index change. Stepping ±1 hid it (the row stays near the viewport), but a jump to the far end left the viewport parked until the next press advanced the scroll.Fix
Watch
selectedRowIDdirectly and scroll to the idonChangedelivers — mirroring the working Sessions tab (onChange(of: store.selectedPID) { newValue in proxy.scrollTo(newValue) }). No behaviour change for stepping; the jump now moves the viewport on the first press. Kept the deliberate no-animation snap.Testing
swiftc -typecheck panel/*.swift shared/*.swift— clean.🤖 Generated with Claude Code