Skip to content

[A11Y-196] Associate the link text label with its input #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexwarren wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −1
Open

[A11Y-196] Associate the link text label with its input #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ed3ab
fix(editor): associate link text label
alexwarren Sep 16, 2026
f2262bd
test(editor): verify link label targets
alexwarren Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/a11y-link-text-label.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@stackoverflow/stacks-editor": patch
---

Associate the visible link text label with its form input.
2 changes: 1 addition & 1 deletion src/rich-text/plugins/link-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class LinkEditor extends PluginInterfaceView<
<label for="link-editor-text-input-${randomId}" class="s-label mb4">${_t(
"link_editor.text_label"
)}</label>
<input id="link-text-href-input-${randomId}" class="s-input js-link-editor-text" type="text" name="text" />
<input id="link-editor-text-input-${randomId}" class="s-input js-link-editor-text" type="text" name="text" />
</div>

<div class="flex--item">
Expand Down
23 changes: 23 additions & 0 deletions test/rich-text/plugins/link-editor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,29 @@ describe("link-editor", () => {
expect(updatedUploadContainer.parentElement).toBeTruthy();
});

it("should associate each visible label with its input", () => {
showLinkEditor(view.editorView);
editor.update(view.editorView);

const container = getViewContainer(editor);
const labels =
container.querySelectorAll<HTMLLabelElement>("label");
const inputs = [
container.querySelector<HTMLInputElement>(
".js-link-editor-href"
),
container.querySelector<HTMLInputElement>(
".js-link-editor-text"
),
];

expect(labels).toHaveLength(2);
labels.forEach((label, index) => {
expect(inputs[index]).toBeInstanceOf(HTMLInputElement);
expect(label.htmlFor).toBe(inputs[index]?.id);
});
});

it("should focus first input when showing image uploader", () => {
// we need to add our DOM to the doc's body in order to make jsdom's "focus" handling work
// see https://github.com/jsdom/jsdom/issues/2586#issuecomment-742593116
Expand Down
Loading