Skip to content

CI: resolve the NuGet cache key once, so the post step never walks the tree #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgravell merged 1 commit into from
Sep 17, 2026
Merged

CI: resolve the NuGet cache key once, so the post step never walks the tree #3231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,26 @@ jobs:
Write-Output "Computed package version: $version"
# Restore is ~80s of the build step on a cold runner, and the package set changes rarely.
#
# Keep this immediately after checkout, and *before* the WSL/redis steps. The key globs the whole
# workspace for **/*.csproj, and once the servers are up there are sixteen redis processes writing
# into that same tree through DrvFs - rdb files into RedisConfigs/Temp, nodes-*.conf into
# RedisConfigs/Cluster, and BGSAVE's temp-<pid>.rdb appearing and being renamed under the walk.
# Enumerating a tree that is changing underneath you is how you get an intermittent
# "hashFiles(...) failed. Fail to hash files under directory ...", which is exactly what this job
# started doing. Nothing here needs redis, so hash a still checkout instead.
# The key globs the whole workspace for **/*.csproj, so it must only ever be computed against a
# still tree. Two things disturb one: the sixteen redis processes writing through DrvFs once the
# servers are up - rdb files into RedisConfigs/Temp, nodes-*.conf into RedisConfigs/Cluster, and
# BGSAVE's temp-<pid>.rdb appearing and being renamed under the walk - and, later, every bin/ and
# obj/ the build produces. Enumerating a tree that is changing underneath you is how you get an
# intermittent "hashFiles(...) failed. Fail to hash files under directory ...".
#
# Hashing here, straight after checkout, keeps the restore safe; but actions/cache re-evaluates
# `key` in its post step to decide what to save, and that runs at the end of the job when the
# churn is at its worst. So resolve it *once*, into an output, and hand the cache action a plain
# string it can reuse at both ends.
- name: Compute NuGet cache key
id: nuget-cache-key
run: |
"value=${{ runner.os }}-nuget-${{ hashFiles('Directory.Packages.props', 'global.json', '**/*.csproj') }}" >> $env:GITHUB_OUTPUT
- name: Cache NuGet packages
uses: actions/cache@v4
with:
path: ~/.nuget/packages
key: ${{ runner.os }}-nuget-${{ hashFiles('Directory.Packages.props', 'global.json', '**/*.csproj') }}
key: ${{ steps.nuget-cache-key.outputs.value }}
restore-keys: ${{ runner.os }}-nuget-
- uses: Vampire/setup-wsl@v7 # v7 is the first version running on Node 24
with:
Expand Down
Loading