Skip to content

make-release: accept comma-joined -Rid from -File callers (fixes the release job's MSB1006) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StArraySharp merged 2 commits into from
Nov 4, 2026
Merged

make-release: accept comma-joined -Rid from -File callers (fixes the release job's MSB1006) #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f5cd3
make-release: accept comma-joined -Rid from -File callers
2228293026 Oct 31, 2026
80f5bf4
Re-trigger CI: transient MSB4018 GetAssemblyAttributes race on the ru…
2228293026 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tools/make-release.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@ param(
)

$ErrorActionPreference = 'Stop'

# `-File` callers pass the RID list as one comma-joined string (the CI does
# `-Rid win-x64,linux-x64`), and [string[]] binds that as a single element --
# the loop then hands `dotnet publish -r win-x64,linux-x64` to MSBuild in one
# piece and MSBuild reads the second RID as a bare switch (MSB1006 "Switch:
# linux-x64"). Split every element on commas and trim, so both caller forms
# (an array or a joined string) reach the loop as one RID per element.
$Rid = @($Rid |
ForEach-Object { $_ -split ',' } |
ForEach-Object { $_.Trim() } |
Where-Object { $_ })

$root = Split-Path -Parent $PSScriptRoot
Push-Location $root
try {
Expand Down
Loading