Skip to content

Add disabled attribute support for form controls - #119

Merged
SpinyOwl merged 18 commits into
developfrom
agent/disabled-attribute
Aug 19, 2026
Merged

Add disabled attribute support for form controls#119
SpinyOwl merged 18 commits into
developfrom
agent/disabled-attribute

Conversation

@SpinyOwl

Copy link
Copy Markdown
Owner

What changed

  • add boolean disabled attribute support for button, input, and textarea
  • expose NodeBuilder.disabled() and live control disabled() state based on attribute presence
  • suppress mouse focus/click/action, keyboard activation/editing, and char input for disabled controls
  • add CSS :disabled pseudo-class support
  • add focused regression tests for state, selector matching, and system event suppression

Semantics

  • disabled follows boolean attribute presence semantics: disabled="false" is still disabled until the attribute is removed
  • unsupported generic elements do not become disabled merely by carrying a disabled attribute
  • disabled button-like controls do not emit ActionEvent

Validation

  • GitHub Actions will run against this PR; local checkout execution was unavailable in the current environment.

Copy link
Copy Markdown
Owner Author

CI validation note: the final head compiles production and test sources successfully and runs 603 core tests. The Gradle clean build is blocked by exactly one existing failure: AbsoluteContainingBlockLayoutTest.layout_whenAbsoluteAutoHeightUsesTopAndBottom_sizesBeforeNestedLayout() with NullPointerException at line 81. The same failure reproduced across earlier PR runs, and this PR does not modify layout code. No disabled-related test failures were reported. CodeQL's Gradle build is consequently blocked by the same test before analysis.

@SpinyOwl
SpinyOwl marked this pull request as ready for review August 19, 2026 20:32
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@SpinyOwl
SpinyOwl merged commit ca43327 into develop Aug 19, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant