Skip to content

Improve Visual Basic comments filtering#97

Open
Vladyslav-Kuksiuk wants to merge 1 commit into
improve-python-filteringfrom
improve-vb-filtering
Open

Improve Visual Basic comments filtering#97
Vladyslav-Kuksiuk wants to merge 1 commit into
improve-python-filteringfrom
improve-vb-filtering

Conversation

@Vladyslav-Kuksiuk

Copy link
Copy Markdown
Collaborator

This PR improves comments filtering for Visual Basic.

Resolves this issue.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this Jul 6, 2026
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk marked this pull request as ready for review July 6, 2026 15:07
@Oleg-Melnik

Copy link
Copy Markdown
Collaborator

Optional cleanup (non-blocking): visualBasicQuotedSegmentEnd structurally mirrors the shared quotedSegmentEnd in marker_comment_filter.go, differing only in escape semantics ("" doubled-quote vs \ backslash). A dedicated function reads clearly here, so no change is needed now — but if a third quote-escaping style ever appears, it'd be worth generalizing the shared helper to take an escape strategy rather than adding another near-duplicate.

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oleg-Melnik LGTM with a minor comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants