Improve Python comments filtering#96
Open
Vladyslav-Kuksiuk wants to merge 2 commits into
Open
Conversation
MykytaPimonovTD
approved these changes
Jul 6, 2026
Collaborator
|
Claude Review LGTM — nothing blocking found. Checked and confirmed clean:
One informational limitation, not a blocker: since Python 3.12 (PEP 701), a multi-line f-string can contain real message = f"""
Total: {
compute_total(items) # real comment
}
"""The filter treats the whole triple-quoted region as opaque text, so such a comment is kept instead of stripped. The failure direction is safe — extra text survives, string content is never corrupted, and the block still closes at the right delimiter — and handling it would require f-string-aware interpolation lexing (as done for C#). Fine to leave as a documented limitation until someone actually hits it. |
Oleg-Melnik
approved these changes
Jul 6, 2026
Oleg-Melnik
left a comment
Collaborator
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with comment from Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Python comments filtering.
Resolves this issue.