Save recording_attributes before run_sorter() - #4795
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Comment on lines
+158
to
+161
| # save recording attributes in case the recording is not serializable or removed after sorting | ||
| rec_attributes = get_rec_attributes(recording) | ||
| rec_attributes_file = output_folder / "recording_attributes.json" | ||
| rec_attributes_file.write_text(json.dumps(check_json(rec_attributes), indent=4), encoding="utf8") |
Member
There was a problem hiding this comment.
Oooh ok this is very nice and simple.
samuelgarcia
commented
Sep 18, 2026
Member
Author
|
@alejoe91 : OK to add this in 0.0105.0 ? |
Co-authored-by: Garcia Samuel <sam.garcia.die@gmail.com>
for more information, see https://pre-commit.ci
alejoe91
reviewed
Sep 18, 2026
for more information, see https://pre-commit.ci
alejoe91
changed the title
recording_attributes before run_sorter()
alejoe91
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alejoe91 @chris
For the kilosort channel_ids stuff.