-
Notifications
You must be signed in to change notification settings - Fork 246
Fix openephys tests #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chrishalcrow
merged 11 commits into
SpikeInterface:main
from
alejoe91:fix-openephys-tests
Mar 9, 2026
+16
−7
Merged
Fix openephys tests #4426
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3dc5729
Test IBL extractors tests failing for PI update
alejoe91 d1a0532
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 33c6769
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 2c94bac
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 a412bd8
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 504e19d
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 cd09c19
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 a1da327
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 ef19a8e
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 a098b51
Merge branch 'main' of github.com:SpikeInterface/spikeinterface
alejoe91 61c317a
Fix OpenEphys tests
alejoe91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I don't understand this fix. This now creates a probe with no
device_channel_indices, which then can't be attached to any recordings?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wait, so probeinterface will set
device_channel_indicesjust basically using a range. So the probes that hit this warning so still havedevice_channel_indices?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, exactly! So in this case it will work as before