Skip to content

Fix order of units in mergeview #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelgarcia merged 4 commits into from
Mar 13, 2026
Merged

Fix order of units in mergeview #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49b5ae3
Fix order of units in mergeview
alejoe91 Feb 25, 2026
06ace68
Use CustomUnitIDColum
alejoe91 Mar 13, 2026
97a2881
Merge branch 'main' of github.com:SpikeInterface/spikeinterface-gui i…
alejoe91 Mar 13, 2026
a7048b9
Simpler fix: use existing CustomUnitIdItem
alejoe91 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spikeinterface_gui/mergeview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def _qt_make_layout(self):

def _qt_refresh(self):
from .myqt import QT
from .utils_qt import CustomItem
from .utils_qt import CustomItem, CustomItemUnitID

self.table.clear()
self.table.setSortingEnabled(False)
Expand All @@ -287,6 +287,7 @@ def _qt_refresh(self):
self.table.setColumnCount(len(labels))
self.table.setHorizontalHeaderLabels(labels)
self.table.setRowCount(len(rows))
unit_ids = self.controller.unit_ids

for r, row in enumerate(rows):
for c, label in enumerate(labels):
Expand All @@ -298,7 +299,7 @@ def _qt_refresh(self):
pix = QT.QPixmap(16, 16)
pix.fill(color)
icon = QT.QIcon(pix)
item = QT.QTableWidgetItem(name)
item = CustomItemUnitID(unit_ids, name)
item.setData(QT.Qt.ItemDataRole.UserRole, unit_id)
item.setFlags(QT.Qt.ItemIsEnabled | QT.Qt.ItemIsSelectable)
self.table.setItem(r, c, item)
Expand Down
8 changes: 6 additions & 2 deletions spikeinterface_gui/utils_qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,14 @@ def __init__(self, unit_ids, *args, **kwargs):
self.unit_ids = [f"{u}" for u in unit_ids]

def __lt__(self, other):
ind = self.unit_ids.index(self.text())
other_ind = self.unit_ids.index(other.text())
# since mergeview has "{unit_id} (n={n_spikes})" as name, we split and keep the first part
unit_id = self.text().split(' ')[0]
other_unit_id = other.text().split(' ')[0]
ind = self.unit_ids.index(unit_id)
other_ind = self.unit_ids.index(other_unit_id)
return ind < other_ind


class OrderableCheckItem(QT.QTableWidgetItem):
# special case for checkbox
def is_checked(self):
Expand Down