Implement curation_callback and set_external_curation#241
Merged
samuelgarcia merged 8 commits intoSpikeInterface:mainfrom Mar 13, 2026
Merged
Implement curation_callback and set_external_curation#241samuelgarcia merged 8 commits intoSpikeInterface:mainfrom
curation_callback and set_external_curation#241samuelgarcia merged 8 commits intoSpikeInterface:mainfrom
Conversation
alejoe91
commented
Feb 24, 2026
| tabs.stylesheets = [] | ||
|
|
||
|
|
||
| def set_external_curation(self, curation_data): |
Member
Author
There was a problem hiding this comment.
@chrishalcrow could this be needed by the Qt backend too? e.g., UnitRefine or similar could use it?
alejoe91
changed the title
curation_callback and set_external_curation
alejoe91
commented
Feb 27, 2026
| self.notify_manual_curation_updated() | ||
| self.notifier.notify_active_view_updated() | ||
|
|
||
| def _panel_update_labels(self): |
Member
Author
There was a problem hiding this comment.
Make full refresh instead, which includes the labels
Member
There was a problem hiding this comment.
Do you plan to do this or can I merge this PR ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239
Option to pass a custom curation callback with kwargs. This can entirely replaced the
Submit to parentfunctionality in panel, since it can be taken care of by the parent app directly.See new test
test_panel_embedded.pyfor demonstration!Similarly, this PR enables bi-directional communication by exposing a
set_external_curationto the panel backend. This will apply the external curation if thecurationviewis available, notify a manual curation changed, and refresh labels in the units table.Replaces #228, since all communication can be now handled externally.