-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add graph.StorageMaintainer interface - BED-8353 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brandonshearin
wants to merge
5
commits into
main
Choose a base branch
from
BED-8353
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package graph | ||
|
|
||
| import ( | ||
| "context" | ||
| ) | ||
|
|
||
| // TargetStorage identifies a region of graph storage that an optimization | ||
| // pass may target. | ||
| type TargetStorage int | ||
|
|
||
| const ( | ||
| Nodes TargetStorage = iota | ||
| Relationships | ||
| ) | ||
|
|
||
| // OptimizeConfig is the resolved configuration for a single OptimizeStorage call. | ||
| // Drivers apply every OptimizeOption to this struct before reading it. | ||
| type OptimizeConfig struct { | ||
| // Targets is the set of storage regions to optimize. A nil or empty | ||
| // slice instructs the driver to optimize every region it knows about. | ||
| Targets []TargetStorage | ||
| } | ||
|
|
||
| // OptimizeOption mutates an OptimizeConfig and is applied in the order | ||
| // passed to Optimize. | ||
| type OptimizeOption func(*OptimizeConfig) | ||
|
|
||
| // OptimizeTargets restricts the optimization pass to the given storage | ||
| // regions. Repeated calls append targets rather than replacing them. | ||
| // Calling OptimizeTargets with no arguments does not change the resolved | ||
| // target set; if no targets are configured by the time OptimizeStorage runs, the | ||
| // driver treats that as "all regions it knows about". | ||
| func OptimizeTargets(targets ...TargetStorage) OptimizeOption { | ||
| return func(c *OptimizeConfig) { | ||
| c.Targets = append(c.Targets, targets...) | ||
| } | ||
| } | ||
|
|
||
| // StorageOptimizer is an optional capability implemented by drivers that | ||
| // can perform storage optimization. Drivers that cannot perform meaningful optimization | ||
| // must not implement this interface; a failed type assertion is the | ||
| // signal for "this driver does not support storage optimization". | ||
| // A non-nil error returned from OptimizeStorage signals a driver-specific failure | ||
| // during a supported call. | ||
| // | ||
| // Consumers detect support with a type assertion against a graph.Database: | ||
| // | ||
| // if m, ok := db.(graph.StorageOptimizer); ok { | ||
| // err := m.Optimize(ctx, graph.OptimizeTargets(graph.Nodes, graph.Relationships)) | ||
| // ... | ||
| // } | ||
| type StorageOptimizer interface { | ||
| // OptimizeStorage runs a storage optimization pass against the regions | ||
| // identified by opts. With no options, every region the driver | ||
| // recognizes is optimized. | ||
| OptimizeStorage(ctx context.Context, opts ...OptimizeOption) error | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| package graph_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/specterops/dawgs/graph" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestOptimizeOptions(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| opts []graph.OptimizeOption | ||
| want []graph.TargetStorage | ||
| }{ | ||
| { | ||
| name: "no options yields nil Targets", | ||
| opts: nil, | ||
| want: nil, | ||
| }, | ||
| { | ||
| name: "OptimizeTargets with no args leaves Targets nil", | ||
| opts: []graph.OptimizeOption{graph.OptimizeTargets()}, | ||
| want: nil, | ||
| }, | ||
| { | ||
| name: "single call preserves order", | ||
| opts: []graph.OptimizeOption{graph.OptimizeTargets(graph.Nodes, graph.Relationships)}, | ||
| want: []graph.TargetStorage{graph.Nodes, graph.Relationships}, | ||
| }, | ||
| { | ||
| name: "repeated calls accumulate", | ||
| opts: []graph.OptimizeOption{ | ||
| graph.OptimizeTargets(graph.Nodes), | ||
| graph.OptimizeTargets(graph.Relationships), | ||
| }, | ||
| want: []graph.TargetStorage{graph.Nodes, graph.Relationships}, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range tests { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| var cfg graph.OptimizeConfig | ||
| for _, o := range tc.opts { | ||
| o(&cfg) | ||
| } | ||
| assert.Equal(t, tc.want, cfg.Targets) | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opinion: While convenient, an empty slice representing "all" supported storage targets may be misleading