Skip to content

chore: rephrasing zone membership BED-7197#2343

Merged
LucasParraF merged 2 commits intomainfrom
BED-7197-User-confirms-analysis-to-update-zone-membership
Feb 10, 2026
Merged

chore: rephrasing zone membership BED-7197#2343
LucasParraF merged 2 commits intomainfrom
BED-7197-User-confirms-analysis-to-update-zone-membership

Conversation

@LucasParraF
Copy link
Copy Markdown
Contributor

@LucasParraF LucasParraF commented Feb 4, 2026

Description

On explore page, when right clicking on a node and selecting Add to Tier Zero, the confirmation modal message was rephrase to keep cohesion with the terminology used on the app

Motivation and Context

Resolves BED-7197

How Has This Been Tested?

Tested locally

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Updated confirmation messages in asset group management dialogs to use consistent terminology throughout the application.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Two confirmation dialog messages in asset group menu item components are updated to use "zone membership" terminology instead of "group membership" when managing Tier Zero asset group operations. No functional or control flow changes are made.

Changes

Cohort / File(s) Summary
Asset Group Menu Dialogs
cmd/ui/src/views/Explore/ContextMenu/AssetGroupMenuItem.tsx, packages/javascript/bh-shared-ui/src/views/Explore/ContextMenu/AssetGroupMenuItemPrivilegeZonesEnabled.tsx
Updated confirmation dialog text to reference "zone membership" instead of "group membership" in two dialog instances for adding/removing nodes from asset groups in Tier Zero scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

user interface

Suggested reviewers

  • mistahj67
  • urangel
  • Holocraft
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description includes required sections and addresses the core change, but testing details are vague and some documentation claims lack specificity. Provide specific details about local testing (e.g., which browsers, environments, or test steps were performed) and clarify which documentation was reviewed to ensure comprehensive validation.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: rephrasing 'group membership' to 'zone membership' in confirmation dialogs across two files, with reference to the Jira ticket BED-7197.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BED-7197-User-confirms-analysis-to-update-zone-membership

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LucasParraF LucasParraF self-assigned this Feb 4, 2026
@LucasParraF LucasParraF added enhancement New feature or request user interface A pull request containing changes affecting the UI code. labels Feb 4, 2026
@LucasParraF LucasParraF merged commit 2927f5b into main Feb 10, 2026
14 checks passed
@LucasParraF LucasParraF deleted the BED-7197-User-confirms-analysis-to-update-zone-membership branch February 10, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request user interface A pull request containing changes affecting the UI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants