Skip to content

DKIM2#848

Open
juliebin wants to merge 66 commits into
mainfrom
1259-dkim2-prototyping
Open

DKIM2#848
juliebin wants to merge 66 commits into
mainfrom
1259-dkim2-prototyping

Conversation

@juliebin

@juliebin juliebin commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
  • Give your PR a recognizable title. For example: "FE-123: Add new prop to component" or "Resolve Issue Create new-pricing-increases-costs #123: Fix bug in component"
  • Your PR title will be visible in changelogs

What Changed

  • What changes does this PR propose?
  • Provide screenshots or screen recordings for any visual changes.

How To Test or Verify

  • Describe any steps that may help reviewers verify changes.
  • Anything beyond basic unit testing, such as assistive tech usage, or special interactions.

PR Checklist

Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.

For example: If you are submitting a content change to one of the support documents, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Content Changes Checklist

If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:

  • "All PRs Checklist"
  • AND the "Development Changes Checklist"

All PRs Checklist

  • Give your pull request a meaningful name.
  • Use lowercase filenames.
  • Apply at least one team label according to which team is the content expert (ie. team-FE or team-SAZ)
  • Pull request approval from the FE team or content experts (see label applied above) that isn't the content creator.

Content Changes Checklist

  • Check that your article looks correct in the preview here or in a Netlify deploy preview.
  • Check the links in your article.
  • Check the images in your article (if there are any)
  • Check to make sure you are using markdown appropriately as outlined in examples/article.md in the root of the project directory and on the momentum doc's preface article
  • Check to make sure the Copy and Tone Guidelines are followed.

Development Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")

  • The appropriate tests are created in cypress/ directory in the root of the project
  • The lighthouse score is passing according to the FE Support Docs' Service Outline SLI/SLOs

Note

Low Risk
Documentation-only changes with no runtime or auth logic; main review risk is accuracy of API names, internal links, and nav anchor paths.

Overview
Adds a new DKIM2 documentation set for Momentum 4, placed alongside the existing DKIM1 articles.

The overview (content/momentum/4/dkim2.md) explains DKIM2 vs DKIM1, dkim2 {} enablement, Lua policy hooks (validate_data_spool_each_rcpt), key reuse, coexistence with DKIM1/ARC, and a long known limitations section (draft spec risk, lower-hop crypto, DSN, forwarders, BCC/rt=, recipes, AR strings, CRLF config).

Child reference pages cover msys.validate.dkim2.sign(), verify(), ar_clauses(), and debug_level / paniclog behavior, with option tables, forwarder/nd= bridge and recipe signing, verify result/reason codes, SMTP guidance, and AR examples.

Navigation (content/momentum/navigation.yml) adds a DKIM2 section under Momentum 4 with links to signing and verifying topics.

Reviewed by Cursor Bugbot for commit a1599a1. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jun 1, 2026

Copy link
Copy Markdown

Deploy Preview for support-docs ready!

Name Link
🔨 Latest commit a1599a1
🔍 Latest deploy log https://app.netlify.com/projects/support-docs/deploys/6a42cd3dde8cb60008ffd332
😎 Deploy Preview https://deploy-preview-848--support-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/using-dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md
Comment thread content/momentum/4/using-dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md
Comment thread content/momentum/4/dkim2.md Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 86efa82. Configure here.

Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2.md Outdated
Comment thread content/momentum/4/dkim2/sign.md Outdated
Comment thread content/momentum/4/dkim2/debug.md Outdated
Comment thread content/momentum/4/dkim2/debug.md Outdated
Comment thread content/momentum/4/dkim2/debug.md Outdated
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
@dkoerichbird dkoerichbird self-requested a review June 25, 2026 16:25
@dkoerichbird dkoerichbird dismissed their stale review June 25, 2026 18:12

Doug taking ownership of PR.

@dkoerichbird dkoerichbird removed their request for review June 25, 2026 18:12
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
@dkoerichbird dkoerichbird requested a review from deepakpn June 29, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants