Issue #212: Compatibility with psr/http-message 2.0#214
Open
omarlopesino wants to merge 3 commits intoSparkPost:masterfrom
Open
Issue #212: Compatibility with psr/http-message 2.0#214omarlopesino wants to merge 3 commits intoSparkPost:masterfrom
omarlopesino wants to merge 3 commits intoSparkPost:masterfrom
Conversation
|
Looks like this library has not been updated for 3 years and is now incompatible with some modern dependencies. I would say it has been abandoned by SparkPost. I have seen this before in vendor supported libraries. I had to do a completely new Constant Contact V3 API as Constant Contact stopped supporting API libraries for all languages. Also SparkPost was recently acquired by MessageBird, so I suspect this library (and SparkPost in general) will not be receiving the attention needed to keep it current. I would be willing to fork and maintain this repo if you want to move your PR to the new fork. |
|
@omarlopesino what http client are you using to pass into SparkPost? |
|
Thanks for the merge request, Looks like abandon ware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts the SparkpostResponse class to be compatible with psr http-message 2.0