Sp/issue102

[stuart-spradling]

No description provided.

[stuart-spradling]

@Crim I got this far and am hung up by the automated tests. The problem I'm running into now is when I try to run the mvn install command or run the tests as a suite. There seems to be some kind of disconnect with the Windows OS where I am getting AccessDeniedException s when running these tests. Maybe you might be able to shed some light on this?

[Crim]

Sure, let me pull down the branch and see what tests pass/fail for me.

[stuart-spradling]

@Crim any luck?

[Crim]

So I'm running on OSX, and excluding the tests that require the special JVM options (KafkaSaslSslClusterTests, KafkaSaslClusterTests) the only test that fails for me is ConsumerGroupOffsetsTest.testSerialization()

Are you able to post an exact error and stack trace?

Thanks

[Crim]

It looks like the failure in ConsumerGroupOffsetsTest.testSerialization() is just the order of elements being serialized in the final json string is slightly rearranged.

[stuart-spradling]

@Crim I fixed the ConsumerGroupOffsetsTest.testSerialization() order of elements issue. For the stack trace, this is the one that keeps me from executing the install command successfully

org.apache.kafka.common.errors.KafkaStorageException: Error while renaming dir for TestTopic-1586197464516-0 in log dir C:\Users\stuarts\AppData\Local\Temp\kafka-unit8519557660001136249 Caused by: java.nio.file.AccessDeniedException: C:\Users\stuarts\AppData\Local\Temp\kafka-unit8519557660001136249\TestTopic-1586197464516-0 -> C:\Users\stuarts\AppData\Local\Temp\kafka-unit8519557660001136249\TestTopic-1586197464516-0.425e2890026940e0b15421aaad0e79 b5-delete at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:387) at sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:287) at java.nio.file.Files.move(Files.java:1395) at org.apache.kafka.common.utils.Utils.atomicMoveWithFallback(Utils.java:786) at kafka.log.Log$$anonfun$renameDir$1.apply$mcV$sp(Log.scala:689) at kafka.log.Log$$anonfun$renameDir$1.apply(Log.scala:687) at kafka.log.Log$$anonfun$renameDir$1.apply(Log.scala:687) at kafka.log.Log.maybeHandleIOException(Log.scala:1842) at kafka.log.Log.renameDir(Log.scala:687) at kafka.log.LogManager.asyncDelete(LogManager.scala:833) at kafka.cluster.Partition$$anonfun$delete$1.apply(Partition.scala:271) at kafka.cluster.Partition$$anonfun$delete$1.apply(Partition.scala:265) at kafka.utils.CoreUtils$.inLock(CoreUtils.scala:251) at kafka.utils.CoreUtils$.inWriteLock(CoreUtils.scala:259) at kafka.cluster.Partition.delete(Partition.scala:265) at kafka.server.ReplicaManager.stopReplica(ReplicaManager.scala:341) at kafka.server.ReplicaManager$$anonfun$stopReplicas$2.apply(ReplicaManager.scala:371) at kafka.server.ReplicaManager$$anonfun$stopReplicas$2.apply(ReplicaManager.scala:369) at scala.collection.Iterator$class.foreach(Iterator.scala:891) at scala.collection.AbstractIterator.foreach(Iterator.scala:1334) at scala.collection.IterableLike$class.foreach(IterableLike.scala:72) at scala.collection.AbstractIterable.foreach(Iterable.scala:54) at kafka.server.ReplicaManager.stopReplicas(ReplicaManager.scala:369) at kafka.server.KafkaApis.handleStopReplicaRequest(KafkaApis.scala:200) at kafka.server.KafkaApis.handle(KafkaApis.scala:111) at kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:69) at java.lang.Thread.run(Thread.java:748)

[Crim]

Do you happen to know which test it is? I'm guessing KafkaOperationsTest.testRemoveTopic()?

If so, it likely is safe to locally comment out / bypass that test as you're unlikely to touch that functionality.

From the Stacktrace, I'm guessing you're hitting this bug in kafka KAFKA-1194 which appears to hit if you the following in windows:

1. Create a topic
2. push messages into the topic
3. delete the topic.

Thoughts?

[Crim]

Also you can run the commend mvn clean install -DskipTests=true to bypass running the test suite.