feat: ignore <style> tag content in markdown#5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Backports behavior to React 18 branch so <style> nodes are skipped during Markdown serialization, preventing CSS from leaking into SSG-MD output.
Changes:
- Update the Markdown serializer to omit
<style>elements from output. - Refactor child-Markdown generation to be lazily evaluated.
- Add a React 18 regression test ensuring
<style>content is ignored.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/react/render.ts | Adds style handling to return empty output and refactors child markdown computation to be lazy. |
| src/react/render.test.tsx | Adds an inline snapshot regression test asserting <style> content is omitted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
240c67f to
9231c4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<style>nodes during Markdown serialization so CSS content is omitted from SSG-MD output.<style>handling on React 18.Testing
pnpm install --frozen-lockfilepnpm testpnpm exec biome check .pnpm build