Skip to content

fix: add confirm dialogs for repeater and block deletes#627

Closed
bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
bobbwal:fix/repeater-delete-confirm
Closed

fix: add confirm dialogs for repeater and block deletes#627
bobbwal wants to merge 1 commit intoSonicJs-Org:mainfrom
bobbwal:fix/repeater-delete-confirm

Conversation

@bobbwal
Copy link
Copy Markdown
Contributor

@bobbwal bobbwal commented Feb 2, 2026

Description

Adds confirmation dialogs when deleting repeater items and content blocks in admin content forms to reduce accidental
deletions.

Fixes #626

Changes

  • Reuse the shared confirmation dialog component for repeater item deletion.
  • Add a separate dialog for block deletion and wire delete handlers to use it.

Testing

  • Manual verification in admin content form (repeaters + blocks)
  • npm run type-check
  • npm run e2e

Unit Tests

  • Added/updated unit tests
  • All unit tests passing

E2E Tests

  • Added/updated E2E tests
  • All E2E tests passing

Checklist

  • Code follows project conventions
  • Tests added/updated and passing
  • Type checking passes
  • No console errors or warnings
  • Documentation updated (if needed)

Generated with Claude Code in Conductor

lane711 pushed a commit that referenced this pull request Mar 28, 2026
Adds confirmation dialogs before deleting repeater items and blocks
to prevent accidental data loss.

Cherry-picked from #627 by @bobbwal
Closes #627

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@lane711 lane711 closed this in #722 Mar 28, 2026
lane711 added a commit that referenced this pull request Mar 28, 2026
Adds confirmation dialogs before deleting repeater items and blocks
to prevent accidental data loss.

Cherry-picked from #627 by @bobbwal
Closes #627

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Rob Walton <bobbwal@users.noreply.github.com>
@lane711
Copy link
Copy Markdown
Collaborator

lane711 commented Apr 1, 2026

Hey @bobbwal — thank you for adding confirm dialogs for repeater and block deletes! This was cherry-picked and merged as PR #722. It shipped in v2.8.3. Really nice UX safety improvement. 🙏

For context: we cherry-pick fork PRs into our own branches to work around GitHub Actions CI limitations with fork secrets. Your authorship is preserved in the git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Confirm dialog for deleting repeater items/blocks

2 participants