BUILD-11961 Use default Vault URL for Maven Artifactory secrets #328
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #!/bin/bash | ||
| # Wait until a SaaS-minted Artifactory token is accepted by an edge node. | ||
| # | ||
| # /api/system/ping is anonymous; use a protected storage API that validates the token. | ||
| # | ||
| # Required environment variables: | ||
| # - ARTIFACTORY_URL: Artifactory base URL (…/artifactory) | ||
| # - ARTIFACTORY_USERNAME: Artifactory username | ||
| # - ARTIFACTORY_ACCESS_TOKEN: Artifactory access token | ||
| # | ||
| # Optional: | ||
| # - REPOX_URL: Instance URL used to skip the wait for SaaS (jfrog.io) | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| REPOX_URL="${REPOX_URL:-${ARTIFACTORY_URL:-}}" | ||
| if [[ "$REPOX_URL" == *jfrog.io* ]]; then | ||
| echo "Skipping token sync wait for SaaS Repox ($REPOX_URL)" | ||
| exit 0 | ||
| fi | ||
|
|
||
| if [[ -z "${ARTIFACTORY_URL:-}" || -z "${ARTIFACTORY_USERNAME:-}" || -z "${ARTIFACTORY_ACCESS_TOKEN:-}" ]]; then | ||
| echo "::error title=Missing Artifactory credentials::Cannot wait for token sync without credentials" | ||
| exit 1 | ||
| fi | ||
|
|
||
| check_url="${ARTIFACTORY_URL%/}/api/storage/sonarsource-qa" | ||
| max_attempts=60 | ||
| sleep_seconds=5 | ||
| attempt=0 | ||
|
|
||
| echo "Waiting for Artifactory token federation sync at $check_url (up to $((max_attempts * sleep_seconds))s)" | ||
|
|
||
| while true; do | ||
| attempt=$((attempt + 1)) | ||
| http_code="$(curl -sS -o /dev/null -w '%{http_code}' \ | ||
| -u "${ARTIFACTORY_USERNAME}:${ARTIFACTORY_ACCESS_TOKEN}" \ | ||
| "$check_url" || echo "000")" | ||
|
Comment on lines
+36
to
+38
There was a problem hiding this comment. 💡 Quality: curl failure appends duplicate http_code outputOn a connection failure curl still emits its Was this helpful? React with 👍 / 👎 |
||
|
|
||
| if [[ "$http_code" == "200" ]]; then | ||
| echo "Artifactory accepted credentials after ${attempt} attempt(s) (HTTP 200)" | ||
| exit 0 | ||
| fi | ||
|
|
||
| if (( attempt >= max_attempts )); then | ||
| echo "::error title=Artifactory token sync timeout::Credentials were not accepted by $check_url" \ | ||
| "within $((max_attempts * sleep_seconds))s (last HTTP ${http_code})" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Attempt ${attempt}/${max_attempts}: HTTP ${http_code}, retrying in ${sleep_seconds}s..." | ||
| sleep "$sleep_seconds" | ||
| done | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Quality: curl retry lacks connect/max timeout
The polling curl has no --connect-timeout/--max-time, so a hung TCP connection to the edge node would stall an iteration indefinitely rather than counting as a failed attempt, defeating the 5-minute bound. Add
--connect-timeout 5 --max-time 15to keep each attempt time-boxed.Bound each curl attempt so a stalled connection can't hang the loop.:
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎