-
Notifications
You must be signed in to change notification settings - Fork 1
BUILD-11500 Use self-hosted Artifactory for Maven actions #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hedinasr
wants to merge
16
commits into
master
Choose a base branch
from
feat/hnasr/BUILD-11500-configMavenArtifactoryInputs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
−33
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0314185
BUILD-11500 Use self-hosted Artifactory for Maven actions
hedinasr 4407515
BUILD-11500 Restore vault-action-wrapper 3.5.0 on Maven actions
hedinasr bdfd8a3
use vault dev
hedinasr a032b28
mvn -U (--update-snapshots)
hedinasr 1875321
pluginRepository updatePolicy always
hedinasr 230867c
remove mvn -U and fetch artifactory token from vault dev
hedinasr 8bac5c3
replace vault github token by github.token
hedinasr 44721dc
BUILD-11500 Use repox-internal self-hosted Artifactory URL
hedinasr 711fa98
BUILD-11500 Use repox-internal self-hosted Artifactory URL
hedinasr ea3783a
BUILD-11500 Use repox-internal self-hosted Artifactory URL
hedinasr ef74319
Merge remote-tracking branch 'origin/master' into feat/hnasr/BUILD-11…
hedinasr ecc266e
BUILD-11500 build-maven: restore vault-action-wrapper 3.6.1 + deploy …
hedinasr 1f349df
BUILD-11500 config-maven/promote: derive vault URL from ARTIFACTORY_U…
hedinasr 4373b48
BUILD-11500 Always fetch secrets from vault.sonar.build (prod) in Mav…
hedinasr fab0f01
BUILD-11500 Fix config-maven reading reader token from wrong vault step
hedinasr 353cb16
BUILD-11500 Lowercase Artifactory username for federated Basic auth
hedinasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the plugin releases repository,
updatePolicywas changed frominterval:60toalways, but the comment directly above it still reads: "no need to always check if new versions are available when executing a Maven plugin without specifying the version". The code now does the exact opposite of what the comment states.Functionally,
alwaysmakes Maven check the remote repository for plugin updates on every single build. For a release (non-snapshot) plugin repository this is almost never desired — released artifacts are immutable, so the only effect is added network round-trips (and slower, less reliable builds) on each invocation.interval:60(ordaily) already balanced freshness against performance.Suggested fix: either revert to
interval:60/daily, or ifalwaysis intentional, update the comment to explain why frequent checks are now required. Note the<releases>repository block above (line 48) still usesinterval:60, so this also introduces an inconsistency between the two repository definitions.Revert to interval:60 to match the comment and the releases repository above.:
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎