Rename Typed-prefixed selector and extractor APIs#28
Closed
blackopsrepl wants to merge 1 commit intomainfrom
Closed
Rename Typed-prefixed selector and extractor APIs#28blackopsrepl wants to merge 1 commit intomainfrom
blackopsrepl wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Superseded by #31, which rebases the rename onto release/0.7.0 and folds in the audit intent from the draft docs branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Typed*prefixes and provide a unified, neutral public API surface for extractors and selectors.Description
TypedEntityExtractor<S,E>toEntityCollectionExtractor<S,E>and updated its impl, Debug name, and all call sites and re-exports.TypedValueSelector -> ValueSelector,StaticTypedValueSelector -> StaticValueSelector, andFromSolutionTypedValueSelector -> FromSolutionValueSelector, and updated implementations and tests accordingly.typed_move_selector.rs -> move_selector.rsandtyped_value.rs -> value_selector.rs, and updated all imports/uses throughout the solver crate.EntityCollectionExtractorand synced the__internalfacade re-exports and WIREFRAME.md files acrosscore,macros,scoring,solver, and the top-level facade to reflect the new public surface.Testing
cargo fmtto normalize formatting andmake buildto compile the full workspace; the build completed successfully.make test(workspace-level); all unit and doc tests completed successfully and returned green.Codex Task