Skip to content

add webid hover on account - #927

Open
SharonStrats wants to merge 2 commits into
stagingfrom
feat/webid-hover
Open

SharonStrats wants to merge 2 commits into
stagingfrom
feat/webid-hover

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator
Screenshot 2026-11-12 at 6 32 58 AM Also for some weird reason there were lots of lint errors on the code editor that didn't come up before.

@SharonStrats SharonStrats self-assigned this Nov 11, 2026
Copilot AI balanced review requested due to automatic review settings November 11, 2026 19:28
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues blocking the account-menu WebID tooltip and accessible-label change.

No open issues 🎉

What changed in this PR

Adds WebID information to the account menu trigger so users can identify the active account on hover and through its accessible name.

Changes:

  • Displays the account’s WebID in a native hover tooltip.
  • Adds an accessible label containing the WebID.
  • Fixes indentation in an existing code editor accessibility test without changing its behavior.
File Description
test/​unit/​codeEditor.test.js Corrects indentation in the accessible-description test.
src/​components/​account/​Account.ts Adds the WebID tooltip and accessible label to the account button.

Review effort: Balanced

@SharonStrats SharonStrats linked an issue Nov 11, 2026 that may be closed by this pull request
@timea-solid

timea-solid commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

I believe we should not implement hover on solidOS because it is not mobile nor accessibility friendly. We need to find other Ui solutions for their need.
Here: I would make the profile heading and the name draggable such that when you drag it to a browser tab you load the webid.
Seeing your webId, I argue, is a dev feature for now. We can of course put this to user feedback later (I collect such points here now: SolidOS/solidos#467) There is another dedicated ticket for that feature.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Add a hover on account see the webid

3 participants