Skip to content

improved messaging around delete container #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timea-solid merged 2 commits into from
Nov 9, 2026
Merged

improved messaging around delete container #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d59fc
improved messaging around delete container
timea-solid Nov 9, 2026
d62ad53
chore: update solidos dependencies (dev: solid-logic@6.0.1-6 solid-ui…
github-actions[bot] Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions src/internal/internalPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,22 @@ const pane: PaneDefinition = {
() => {
if (deletionPending) return
const resourceLabel = utils.label(subject) || subject.value
return confirmDeletion(`Are you sure you want to delete "${resourceLabel}"?\nThis can't be undone.`)
const deleteMessage = isFolder
? `Are you sure you want to delete "${resourceLabel}" and all its contents?\nThis can't be undone.`
: `Are you sure you want to delete "${resourceLabel}"?\nThis can't be undone.`
Comment thread
timea-solid marked this conversation as resolved.
Resolved
return confirmDeletion(deleteMessage)
.then(confirmed => {
if (!confirmed) return
deletionPending = true
deleteButton.disabled = true
const resourceLogic = context.session.logic?.resource || solidLogicSingleton.resource
return resourceLogic.recursiveDelete(subject)
.then(() => {
const str = `Deleted "${resourceLabel}"`
console.log(str)
showMessage('Resource deleted', str)
const confirmDeleteMessage = isFolder
? `Deleted "${resourceLabel}" and all of its contents.`
: `Deleted "${resourceLabel}".`
console.log(confirmDeleteMessage)
showMessage('Resource deleted', confirmDeleteMessage)
dom.dispatchEvent(new CustomEvent('solid-resource-deleted', {
detail: { resource: subject }
}))
Expand Down
Loading