all methods now log and raise exceptions to the caller#25
Closed
Eric Hibbs (flowstate) wants to merge 1 commit intomainfrom
Closed
all methods now log and raise exceptions to the caller#25Eric Hibbs (flowstate) wants to merge 1 commit intomainfrom
Eric Hibbs (flowstate) wants to merge 1 commit intomainfrom
Conversation
Eric Hibbs (flowstate)
requested review from
Douglas (dacoburn),
John-David Dalton (jdalton),
Mikola Lysenko (mikolalysenko) and
Orlando Barrera II (obarrera)
and removed request for
a team,
John-David Dalton (jdalton) and
Mikola Lysenko (mikolalysenko)
Contributor
Author
|
Closing. We will homogenize this behavior when we move to v3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every single SDK method that wraps an API request now logs errors and raises the exception to be handled by the caller.