Merged
Conversation
Douglas (dacoburn)
requested review from
Ryan Eberhardt (reberhardt7) and
Trevor Norris (trevnorris)
and removed request for
a team
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.38.dev1Docker image: |
Douglas (dacoburn)
added
the
Product Changelog
Orlando Barrera II (obarrera)
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue with failing topLevelAncestor check
Root Cause
There was still a code path where it wasn't checked if topLevelAncestor was None before using. This causes the CLI to fail
Fix
Added a return of the empty result in the case where topLevelAncestor was None
Public Changelog