Skip to content

remove process timeout from reachability analysis#141

Merged
Douglas (dacoburn) merged 2 commits intomainfrom
remove-reachability-process-timeout
Dec 18, 2025
Merged

remove process timeout from reachability analysis#141
Douglas (dacoburn) merged 2 commits intomainfrom
remove-reachability-process-timeout

Conversation

@mtorp
Copy link
Copy Markdown
Contributor

Root Cause

There should be no process timeout on the reachability process since it handles the timeout itself.

Fix

Public Changelog

N/A

@mtorp Martin Torp (mtorp) requested a review from a team as a code owner December 18, 2025 09:12
@mtorp Martin Torp (mtorp) requested review from Jake Verbaten (Raynos) and Alex (alxhotel) and removed request for a team December 18, 2025 09:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 18, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.56.dev1

Docker image: socketdev/cli:pr-141

Copy link
Copy Markdown
Contributor

@dacoburn Douglas (dacoburn) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I think I added it in originally to deal with the Reachability Engine not always exiting properly

@dacoburn Douglas (dacoburn) merged commit 30574b8 into main Dec 18, 2025
6 checks passed
@dacoburn Douglas (dacoburn) deleted the remove-reachability-process-timeout branch December 18, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants