ensure the target directory is handled correctly by the reachability analysis#811
Closed
Martin Torp (mtorp) wants to merge 5 commits intomainfrom
Closed
ensure the target directory is handled correctly by the reachability analysis#811Martin Torp (mtorp) wants to merge 5 commits intomainfrom
Martin Torp (mtorp) wants to merge 5 commits intomainfrom
Conversation
…a-228-the-reachability-analysis-ignores-targets
…s' of github.com:SocketDev/socket-cli into martin/rea-228-the-reachability-analysis-ignores-targets
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
Oct 29, 2025
Add missing reachMinSeverity property to reach configuration objects in handle-ci.mts and create-scan-from-github.mts. Convert spinner type from null to undefined using nullish coalescing in reachability analysis calls. Fix spawnSync usage in provider-factory.mts to handle Buffer/string stdout properly without encoding option. Related to PR #811 and PR #827.
Contributor
|
Manually merged 514654f |
John-David Dalton (jdalton)
deleted the
martin/rea-228-the-reachability-analysis-ignores-targets
branch
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
Nov 13, 2025
Add missing reachMinSeverity property to reach configuration objects in handle-ci.mts and create-scan-from-github.mts. Convert spinner type from null to undefined using nullish coalescing in reachability analysis calls. Fix spawnSync usage in provider-factory.mts to handle Buffer/string stdout properly without encoding option. Related to PR #811 and PR #827.
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
Nov 24, 2025
Add missing reachMinSeverity property to reach configuration objects in handle-ci.mts and create-scan-from-github.mts. Convert spinner type from null to undefined using nullish coalescing in reachability analysis calls. Fix spawnSync usage in provider-factory.mts to handle Buffer/string stdout properly without encoding option. Related to PR #811 and PR #827.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the target directory was ignored by the reachability analysis.
For example,
socket scan reach .ran the same reachability analysis assocket scan reach ./foo.There are some constraints added to the targets when running in reachability analysis:
cwd.These constraints are added because the reachability analysis is meant to run on the root of a project.