fix(telemetry): bound processing of prefixed metadata headers - #631
Open
sfc-gh-ikryvanos wants to merge 1 commit into
Open
fix(telemetry): bound processing of prefixed metadata headers#631sfc-gh-ikryvanos wants to merge 1 commit into
sfc-gh-ikryvanos wants to merge 1 commit into
Conversation
logMetadata attached each prefixed metadata value with its own WithValues call (O(N^2) slice copies) and both it and passAlongMetadata processed an unbounded number of caller-supplied headers before authorization. A flood of headers could therefore exhaust CPU/memory and spam the audit log. Collect prefixed pairs once, cap the pair count and per-value length, and attach/forward them in a single call. Adds a unit test for the bounds. Co-authored-by: Cursor <cursoragent@cursor.com>
![arcticowl-ai-review-labs[bot]](https://avatars.githubusercontent.com/u/58992620?s=60&v=4){kind=small}
Comment on lines
+58
to
+70
| for k, v := range md { | ||
| if !strings.HasPrefix(k, sansshellMetadata) { | ||
| continue | ||
| } | ||
| for _, val := range v { | ||
| if len(pairs)/2 >= maxSansshellMetadataPairs { | ||
| return pairs | ||
| } | ||
| if len(val) > maxSansshellMetadataValueLen { | ||
| val = val[:maxSansshellMetadataValueLen] | ||
| } | ||
| pairs = append(pairs, k, val) | ||
| } |
There was a problem hiding this comment.
🟠 MEDIUM · Unsanitized caller-controlled gRPC metadata logged verbatim, enabling audit-log injection [NEW] · CWE-117
sfc-gh-mjankowski
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logMetadata attached each prefixed metadata value with its own WithValues call (O(N^2) slice copies) and both it and passAlongMetadata processed an unbounded number of caller-supplied headers before authorization. A flood of headers could therefore exhaust CPU/memory and spam the audit log.
Collect prefixed pairs once, cap the pair count and per-value length, and attach/forward them in a single call. Adds a unit test for the bounds.