Skip to content

Improve web renderer navigation layout and AttributedText badges#103

Closed
clholgat wants to merge 1 commit into
mainfrom
clholgat/website_port
Closed

Improve web renderer navigation layout and AttributedText badges#103
clholgat wants to merge 1 commit into
mainfrom
clholgat/website_port

Conversation

@clholgat
Copy link
Copy Markdown
Collaborator

@clholgat clholgat commented Jun 1, 2026

Add optional WebNavStack buildUrl hook and flex column page shells so nested Subscreen scroll views size correctly on web. Render outerOutlineColor as pill badges in parseAttributedText with font token parsing and color conversion. Fix projectsync output paths for nested res/ directories and zune-jpeg crate features for the resvg Bazel graph.

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (please describe)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Additional Context

Add optional WebNavStack buildUrl hook and flex column page shells so
nested Subscreen scroll views size correctly on web. Render outerOutlineColor
as pill badges in parseAttributedText with font token parsing and color
conversion. Fix projectsync output paths for nested res/ directories and
zune-jpeg crate features for the resvg Bazel graph.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the area/build-system Bazel build rules and config label Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Sensitive Files Detected

📦 Dependency change — Modifies the Bazel module graph — needs runtime team review after import.

🔧 Build rules — Affects build rules for all Valdi consumers.

This is an automated notice. A maintainer will review after import.

@github-actions github-actions Bot added the size/M label Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

📊 PR Size: size/M

Total changes: 89 lines (7 files)

Top files changed:

  • src/valdi_modules/src/valdi/web_renderer/src/utils/parseAttributedText.ts: +25 -3
  • src/valdi_modules/src/valdi/web_renderer/src/WebNavStack.ts: +20 -4
  • npm_modules/cli/package-lock.json: +12 -4
  • bzl/valdi/valdi_projectsync.bzl: +6 -2
  • third-party/resvg/cargo-bazel-lock.json: +2 -5
  • third-party/pngquant/cargo-bazel-lock.json: +2 -2
  • MODULE.bazel: +1 -1

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

⚠️ Bazel & CI Test Results

Test Suite Result
Linux: Build & Export ❌ failure
Linux: C++ Tests ❌ failure
Snapshot Tests ❌ failure
Valdi Smoke Tests ❌ failure
Comment Test Results / Post Results Comment ❌ null

Some tests failed. Please check the workflow logs for details.

🚀 Bazel disk cache is enabled - builds with warm cache will be faster!

Workflow: Valdi CI

@clholgat clholgat closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build-system Bazel build rules and config size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant