Improve web renderer navigation layout and AttributedText badges#103
Closed
clholgat wants to merge 1 commit into
Closed
Improve web renderer navigation layout and AttributedText badges#103clholgat wants to merge 1 commit into
clholgat wants to merge 1 commit into
Conversation
Add optional WebNavStack buildUrl hook and flex column page shells so nested Subscreen scroll views size correctly on web. Render outerOutlineColor as pill badges in parseAttributedText with font token parsing and color conversion. Fix projectsync output paths for nested res/ directories and zune-jpeg crate features for the resvg Bazel graph. Co-authored-by: Cursor <cursoragent@cursor.com>
Sensitive Files Detected📦 Dependency change — Modifies the Bazel module graph — needs runtime team review after import. 🔧 Build rules — Affects build rules for all Valdi consumers. This is an automated notice. A maintainer will review after import. |
📊 PR Size: size/MTotal changes: 89 lines (7 files) Top files changed:
Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
|
| Test Suite | Result |
|---|---|
| Linux: Build & Export | ❌ failure |
| Linux: C++ Tests | ❌ failure |
| Snapshot Tests | ❌ failure |
| Valdi Smoke Tests | ❌ failure |
| Comment Test Results / Post Results Comment | ❌ null |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel disk cache is enabled - builds with warm cache will be faster!
Workflow: Valdi CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional WebNavStack buildUrl hook and flex column page shells so nested Subscreen scroll views size correctly on web. Render outerOutlineColor as pill badges in parseAttributedText with font token parsing and color conversion. Fix projectsync output paths for nested res/ directories and zune-jpeg crate features for the resvg Bazel graph.
Description
Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context