Skip to content

Concurrently Issue All dist_feature.async_get()Requests in Base Sampler _collate_fn()#690

Merged
jchmura-sc merged 15 commits into
mainfrom
jchmura/concurrent_async_get
Jul 24, 2026
Merged

Concurrently Issue All dist_feature.async_get()Requests in Base Sampler _collate_fn()#690
jchmura-sc merged 15 commits into
mainfrom
jchmura/concurrent_async_get

Conversation

@jchmura-sc

@jchmura-sc jchmura-sc commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Base Sampler Collate Time (s)

Experiment RPC Mean (s) Median (s)
No Edge Feats (Colocated) Baseline 1.33 0.77
Parallel 1.30 (-2.0%) 0.77 (-0.0%)
No Edge Feats (GraphStore) Baseline 6.33 5.81
Parallel 4.26 (-32.6%) 3.27 (-43.6%)
Edge Feats(Colocated) Baseline 1.68 1.67
Parallel 1.54 (-7.6%) 1.56 (-6.4%)

Note: Summary statistics computed over mean_collate_s, which averaged across 500 collate calls.

Close #689

@jchmura-sc jchmura-sc self-assigned this Jul 8, 2026
@jchmura-sc

jchmura-sc commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

/unit_test

@github-actions

github-actions Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:40:24UTC : 🔄 Python Unit Test started.

@ 19:45:22UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:40:26UTC : 🔄 Scala Unit Test started.

@ 18:50:44UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:40:31UTC : 🔄 C++ Unit Test started.

@ 18:42:28UTC : ✅ Workflow completed successfully.

@jchmura-sc
jchmura-sc marked this pull request as ready for review July 8, 2026 19:57
kmontemayor2-sc
kmontemayor2-sc reviewed Jul 8, 2026
View reviewed changes

@kmontemayor2-sc kmontemayor2-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work Jacob! I would appreciate if we can test this at scale, is it possible to do so and follow up offline?

Comment thread gigl/distributed/base_sampler.py Outdated
Comment thread gigl/distributed/base_sampler.py Outdated
@jchmura-sc

jchmura-sc commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

/unit_test

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 16:21:36UTC : 🔄 C++ Unit Test started.

@ 16:23:29UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 16:21:38UTC : 🔄 Scala Unit Test started.

@ 16:30:11UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 16:21:42UTC : 🔄 Python Unit Test started.

@ 17:31:40UTC : ✅ Workflow completed successfully.

kmontemayor2-sc
kmontemayor2-sc reviewed Jul 23, 2026
View reviewed changes
Comment thread gigl/distributed/base_sampler.py Outdated
Comment thread gigl/distributed/base_sampler.py Outdated
Comment thread gigl/distributed/base_sampler.py Outdated
@jchmura-sc

jchmura-sc commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

/unit_test

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 20:49:56UTC : 🔄 Python Unit Test started.

@ 22:05:04UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 20:49:57UTC : 🔄 C++ Unit Test started.

@ 20:51:45UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 20:50:00UTC : 🔄 Scala Unit Test started.

@ 21:00:33UTC : ✅ Workflow completed successfully.

@jchmura-sc
jchmura-sc enabled auto-merge July 23, 2026 21:27
@jchmura-sc
jchmura-sc added this pull request to the merge queue Jul 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 23, 2026
@jchmura-sc
jchmura-sc added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit d89b33b Jul 24, 2026
7 checks passed
@jchmura-sc
jchmura-sc deleted the jchmura/concurrent_async_get branch July 24, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliu2-sc yliu2-sc yliu2-sc approved these changes
@kmontemayor2-sc kmontemayor2-sc kmontemayor2-sc approved these changes
@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner
@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner
@mkolodner-sc mkolodner-sc Awaiting requested review from mkolodner-sc mkolodner-sc is a code owner
@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner
@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

@jchmura-sc jchmura-sc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Concurrently Issue All dist_feature.async_get()Requests in Base Sampler _collate_fn()

3 participants

@jchmura-sc @yliu2-sc @kmontemayor2-sc