fix(release): sync-versions step 3 skips operator-core git dep#199
Open
brentrager wants to merge 1 commit into
Open
fix(release): sync-versions step 3 skips operator-core git dep#199brentrager wants to merge 1 commit into
brentrager wants to merge 1 commit into
Conversation
The version PR broke on 'failed to select a version for smooai-smooth-operator-core = ^0.18.0': sync-versions.mjs step 3 (add missing version) stamped the workspace version onto the smooth-operator git dep, which the pinned rev can't provide. Step 2 already skipped it; step 3 now does too. This is the durable fix for the release-blocking issue (the release branch was also patched directly to unblock the current release). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vg7frHqHSAUXhQiRNdr3NW
🦋 Changeset detectedLatest commit: 692fd43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Changesets version PR (#156,
🦋 New version release) fails its Rust checks with:Root cause:
scripts/sync-versions.mjsstep 3 (add aversionto workspace deps that lack one) stamps the workspace version onto the externalsmooth-operatorgit dependency ({ git, rev="b43c04fe", package="smooai-smooth-operator-core" }), which carries no version onmain. The pinned rev provides the core at 0.15.0, so^0.18.0is unsatisfiable → resolver fails on the version PR. Step 2 already skipped operator-core; step 3 forgot to — so it recurs every release.Fix
Apply the same
smooai-smooth-operator-coreskip in step 3's replace callback. One-line-equivalent change mirroring step 2. (The current release branch was also patched directly to unblock this release; this is the durable fix so it doesn't recur.)Pearl th-1ee32b tracks this class of issue.
🤖 Generated with Claude Code