Skip to content

Herget new - #554

Open
awilson110 wants to merge 6 commits into
mainfrom
herget_new
Open

Herget new#554
awilson110 wants to merge 6 commits into
mainfrom
herget_new

Conversation

@awilson110

Copy link
Copy Markdown
Collaborator

Fixes #311

This is the Herget method but rebased for the updated version of main. For previous discussions see PR #502

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Layup run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@awilson110 awilson110 mentioned this pull request Sep 7, 2026
5 tasks
@mschwamb

mschwamb commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

@awilson110 are you aware that this PR needs to address the new linked tickets?

@awilson110

Copy link
Copy Markdown
Collaborator Author

@awilson110 are you aware that this PR needs to address the new linked tickets?

Yep, I'm working on it now

@awilson110

Copy link
Copy Markdown
Collaborator Author

This isn't a final version, still need to resolve that merge conflict and address #556 and #559 (I've left comments in those issues to discuss)

@awilson110

Copy link
Copy Markdown
Collaborator Author

addressed #556 and #559 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Herget IOD method

2 participants