philips-hue: pass correct argument in device initialization#3124
Draft
NoahCornell wants to merge 1 commit into
Draft
philips-hue: pass correct argument in device initialization#3124NoahCornell wants to merge 1 commit into
NoahCornell wants to merge 1 commit into
Conversation
NoahCornell
requested review from
cjswedes,
ctowns,
hcarter-775,
varzac and
z-michel
July 15, 2026 16:11
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a22759f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
The added handlers for devices expect this argument to be a device rid and not the entire description. This causes the lookup for the entire description to fail and sends the device back to the stray device loop which sends it back to be initialized and loops over and over. This is specific to non-light devices because the light devices will attempt to get the info from the bridge inside the added handlers (which will fail) but the other added handlers do not.
I need to spend some time reproducing and testing but I believe this happens only after doing a hue bridge pro migration. After this migration, the migrated devices share the same hue resource ids. As seen in the fix for onboarding a migrated hue bridge pro here: #2389. Even though the original hue bridge cannot be communicated with, the stray device handler will find info for the stray devices from the hue bridge because the cache is keyed by the RIDs. This may require further changes to separate the discovery cache by bridge similar to the previous pull request but I think this should be fine as is because this info is only used to map the RID to device which is already separated by bridge.
Summary of Completed Tests
TBD after finding a hue bridge pro. Keeping in draft until I can test.