PNG: Should Not Throw Exception when alpha.Length > colorTable.Length in tRNS chunk#3084
Merged
JimBobSquarePants merged 3 commits intomainfrom Mar 12, 2026
Merged
PNG: Should Not Throw Exception when alpha.Length > colorTable.Length in tRNS chunk#3084JimBobSquarePants merged 3 commits intomainfrom
JimBobSquarePants merged 3 commits intomainfrom
Conversation
| if (alpha.Length > colorTable.Length) | ||
| { | ||
| throw new InvalidImageContentException( | ||
| "The tRNS chunk contains more alpha values than there are palette entries."); |
Member
There was a problem hiding this comment.
Should we perhaps slice the chunk entries to the correct length instead?
Collaborator
Author
There was a problem hiding this comment.
yes, I think that's better, I have changed it in c512b14
JimBobSquarePants
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR changes AssignColorPalette() and throws a
InvalidImageContentExceptionwhen alpha.Length > colorTable.Length, which is not allowed according to spec. This fixes #3082