Make DrawingTextCache thread-safe - #420
Merged
Merged
Conversation
Protect cache metadata, publish complete glyph entries, and lease reusable working buffers to each drawing operation. Keep outline construction and rasterization unchanged. Add tests for concurrent drawing, outline reuse, complete publication, eviction, clearing, and buffer ownership. Update Fonts to 3.1.2 and ImageSharp to 4.1.2. Validation: Full Release suite passed on .NET 8 and .NET 10, with 2,754 passed and 9 skipped per target.
Use `Task.Factory.StartNew` with `TaskCreationOptions.LongRunning` in the concurrent drawing text cache tests so each barrier participant gets a dedicated thread. This avoids thread-pool starvation and intermittent failures on small CI runners when other tests are also scheduling work.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/3.1.x #420 +/- ##
=============================================
Coverage 80% 80%
=============================================
Files 232 232
Lines 27359 27392 +33
Branches 3114 3120 +6
=============================================
+ Hits 21896 21959 +63
+ Misses 4576 4540 -36
- Partials 887 893 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Protect cache metadata, publish complete glyph entries, and lease reusable working buffers to each drawing operation. Keep outline construction and rasterization unchanged.
Add tests for concurrent drawing, outline reuse, complete publication, eviction, clearing, and buffer ownership. Update Fonts to 3.1.2 and ImageSharp to 4.1.2.
Validation: Full Release suite passed on .NET 8 and .NET 10, with 2,754 passed and 9 skipped per target.