Repository navigation
Add std-free Pentagonal XOR C API with legacy Windows target selection - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_WIN32and_WIN32_WINNT; document that this describes the build target, not the runtime host OS.Validation
The existing workflow should compile C11 and C++20 targets and run the added numeric tests alongside the existing security-guard tests on Linux, Windows, and macOS. This PR has not yet been validated by GitHub Actions; results will be checked after the run starts.
Scope notes
The header expects five finite feature values in
[0,1]for the combined score API. The fifth-root helper supports finite signed inputs; NaN and infinities are outside its contract. The Windows macro is compile-time target selection, not reliable runtime OS detection.