feat(autojac): Make jac_to_grad return optional weights.#585
Closed
PierreQuinton wants to merge 2 commits intomainfrom
Closed
feat(autojac): Make jac_to_grad return optional weights.#585PierreQuinton wants to merge 2 commits intomainfrom
jac_to_grad return optional weights.#585PierreQuinton wants to merge 2 commits intomainfrom
Conversation
* Change `aggregator: Aggregator` to `method: Aggregator | Weighting` and return type to optional `Tensor`. * Make `method` positional only. * Add overloads to rename `method` to `aggregator` or `weighting` and link it to output type. * Compute the weights if we provide a weighting and return them. * Update the doc and add a usage example
PierreQuinton
added
cc: feat
Contributor
Author
|
Closed in favor of #586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aggregator: Aggregatortomethod: Aggregator | Weightingand return type to optionalTensor.methodpositional only.methodtoaggregatororweightingand link it to output type.What I like are the overloads, they are super smooth with the fact that we can actually specify the names
aggregatorandweighting. I think this also combine well with the Gramian optimization, for instance if we don't want to make it systematic, then we can add a fielduse_gramian_optimization.I think that going this way requires us to refactor the aggregation package. The current error is due to the fact that we call a Gramian weighting on a matrix and not on its gramian.