-
Notifications
You must be signed in to change notification settings - Fork 0
Update Specifications #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ff56ff5
656077e
c38768d
42fdd28
e4ba5c3
cfb2179
ce4a064
5093cd0
e9f43de
0f9204e
4d59eae
2f152b9
4622fa8
bc7539b
cf12fd9
5b80562
408e337
fa88281
1c03eaa
933d611
55c9d18
6f9a91b
b45c08b
11e62bf
1642b37
360072b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| (?i)pixmap | ||
| (?i)pixmaps |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| StylesPath = .ci/styles | ||
|
|
||
| Vocab = SimplePixelFont | ||
| Packages = Google, write-good, proselint | ||
|
|
||
| [.ci/styles/proselint/*.md] | ||
| BasedOnStyles = | ||
|
|
||
| [*.md] | ||
| BasedOnStyles = Vale, Google, write-good, proselint | ||
| BasedOnStyles = Vale, Google, write-good, proselint |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The exact code point length of each `code_points` field in this table |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `use_constant_code_point_count` is enabled. | ||
|
Check notice on line 1 in snippets/character_table/configurations/condition/constant_code_point_count.md
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| All characters in this table have the same number of code points. |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Vector of Pixmap Table indices this character table references. | ||
| Length byte followed by that many Pixmap Table indices this character table may reference. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| When disabled, the pixmap index defaults to match the character record index (1:1 mapping). | ||
| When disabled, the pixmap index defaults to match the character record index creating a one to one mapping. | ||
|
Check warning on line 1 in snippets/character_table/modifiers/details/use_pixmap_index.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| UTF-8 encoded code point sequence, null-terminated unless `constant_code_point_count` is set. | ||
|
Check notice on line 1 in snippets/character_table/records/brief/code_points.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| If `use_pixmap_index` modifier is enabled. | ||
| Index of the pixmap within the referenced Pixmap Tables. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| If `use_pixmap_table_index` modifier is enabled. | ||
| Index of the specific Pixmap Table to use for this character. |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Index of the pixmap within the referenced Pixmap Table(s). | ||
| If `use_pixmap_index` modifier is enabled. | ||
|
Check notice on line 1 in snippets/character_table/records/condition/pixmap_index.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Index of the specific Pixmap Table to use for this character. | ||
| If `use_pixmap_table_index` modifier is enabled. | ||
|
Check notice on line 1 in snippets/character_table/records/condition/pixmap_table_index.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # color_table table | ||
| Stores RGBA color values that can be referenced by pixmap data. | ||
|
Check notice on line 1 in snippets/color_table/brief.md
|
||
|
|
||
| Write the documentation content for color_table table here. | ||
| ## Use Cases | ||
|
Check warning on line 3 in snippets/color_table/brief.md
|
||
|
|
||
| - **Pixmap palettes** - When linked to a Pixmap Table, provides the color palette for indexed pixel data. | ||
| - **Color storage** - Can store color sets independently for other purposes. | ||
|
Comment on lines
+1
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Address Vale spelling failures for This file currently fails lint. Please use lint-approved wording (or the project’s accepted glossary form) so docs checks pass. 🧰 Tools🪛 GitHub Actions: vale / 1_vale.txt[error] 1-1: Vale.Spelling: Did you really mean 'pixmap'? [error] 5-5: Vale.Spelling: Did you really mean 'Pixmap'? [error] 5-5: Vale.Spelling: Did you really mean 'Pixmap'? 🪛 GitHub Actions: vale / vale[error] 1-1: [Vale.Spelling] Did you really mean 'pixmap'? [error] 5-5: [Vale.Spelling] Did you really mean 'Pixmap'? [error] 5-5: [Vale.Spelling] Did you really mean 'Pixmap'? 🪛 GitHub Check: vale[notice] 1-1: [vale] snippets/color_table/brief.md#L1 [warning] 1-1: [vale] snippets/color_table/brief.md#L1 [notice] 1-1: [vale] snippets/color_table/brief.md#L1 [notice] 1-1: [vale] snippets/color_table/brief.md#L1 [failure] 1-1: [vale] snippets/color_table/brief.md#L1 [warning] 3-3: [vale] snippets/color_table/brief.md#L3 [failure] 5-5: [vale] snippets/color_table/brief.md#L5 [failure] 5-5: [vale] snippets/color_table/brief.md#L5 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # constant_alpha | ||
|
|
||
| Write the documentation content for constant_alpha here. | ||
| The alpha channel value applied to all colors in this table. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `use_constant_alpha` is enabled. | ||
|
Check notice on line 1 in snippets/color_table/configurations/condition/constant_alpha.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| All colors in this table share the same alpha value. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # use_color_type | ||
|
|
||
| Write the documentation content for use_color_type here. | ||
| Each record includes a `color_type` field indicating the color mutability type. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # use_color_type details | ||
|
|
||
| Write the documentation content for use_color_type details here. | ||
| When disabled, the default color type is dynamic. The rendering engine may change the RGBA color to support features such as, but not limited to; text color, and/or palette theming. | ||
|
Check warning on line 1 in snippets/color_table/modifiers/details/use_color_type.md
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Fix the punctuation in the “but not limited to” clause. Use a colon or rewrite the sentence, for example: “The rendering engine may change the RGBA color for text-color changes and palette theming.” 🧰 Tools🪛 GitHub Check: vale[warning] 1-1: [vale] snippets/color_table/modifiers/details/use_color_type.md#L1 [notice] 1-1: [vale] snippets/color_table/modifiers/details/use_color_type.md#L1 [notice] 1-1: [vale] snippets/color_table/modifiers/details/use_color_type.md#L1 [notice] 1-1: [vale] snippets/color_table/modifiers/details/use_color_type.md#L1 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # alpha | ||
|
|
||
| Write the documentation content for alpha here. | ||
| Alpha channel value (0 = fully transparent, 255 = fully opaque). | ||
|
Check notice on line 1 in snippets/color_table/records/brief/alpha.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # blue | ||
|
|
||
| Write the documentation content for blue here. | ||
| Blue channel value. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # color_type | ||
|
|
||
| Write the documentation content for color_type here. | ||
| Color Type value (0 = Dynamic, 1 = Absolute). | ||
|
Check notice on line 1 in snippets/color_table/records/brief/color_type.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # green | ||
|
|
||
| Write the documentation content for green here. | ||
| Green channel value. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # red | ||
|
|
||
| Write the documentation content for red here. | ||
| Red channel value. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `constant_alpha` configuration is **not** set | ||
|
Check notice on line 1 in snippets/color_table/records/condition/alpha.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `use_color_type` modifier is enabled. | ||
|
Check notice on line 1 in snippets/color_table/records/condition/color_type.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # font_table table | ||
|
|
||
| Write the documentation content for font_table table here. | ||
| Groups Character Tables into named fonts and carries the metadata to identify them. | ||
|
|
||
| ## Use Cases | ||
|
Check warning on line 3 in snippets/font_table/brief.md
|
||
|
|
||
| - **Sub-font grouping** - A single file can carry several related fonts, such as Regular, Bold, and Italic, each pointing at its own Character Tables. | ||
|
Check warning on line 5 in snippets/font_table/brief.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # character_tables | ||
|
|
||
| Write the documentation content for character_tables here. | ||
| Length byte followed by that many Character Table indices this font table may reference. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `link_character_tables` is enabled. | ||
|
Check notice on line 1 in snippets/font_table/links/condition/character_tables.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This table links to one or more Character Tables. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # author | ||
|
|
||
| Write the documentation content for author here. | ||
| Author, manufacturer, or credits for the font. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # character_table_indexes | ||
|
|
||
| Write the documentation content for character_table_indexes here. | ||
| Length byte followed by that many Character Table indices this font may access and use. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # font_type | ||
|
|
||
| Write the documentation content for font_type here. | ||
| Style of this font (0 = Regular, 1 = Bold, 2 = Italic). | ||
|
Check notice on line 1 in snippets/font_table/records/brief/font_type.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # name | ||
|
|
||
| Write the documentation content for name here. | ||
| Human-readable font name. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # version | ||
|
|
||
| Write the documentation content for version here. | ||
| Revision number of this font, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Remove the trailing comma. Line 1 should end with a period so the generated description is grammatically complete. 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Always present. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # pixmap_table table | ||
| Stores glyph data as collections of pixels within pixmaps, representing the visual appearance of a character. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win Add Pixmap terminology to the Vale vocabulary. These valid specification terms currently fail documentation CI.
🧰 Tools🪛 GitHub Actions: vale / 1_vale.txt[error] 1-1: [Vale.Spelling] Did you really mean 'pixmap'? 🪛 GitHub Actions: vale / vale[error] 1-1: Vale.Spelling: Did you really mean 'pixmaps'? 🪛 GitHub Check: vale[failure] 1-1: [vale] snippets/pixmap_table/brief.md#L1 📍 Affects 5 files
🤖 Prompt for AI AgentsSource: Pipeline failures |
||
|
|
||
| Write the documentation content for pixmap_table table here. | ||
| ## Use Cases | ||
|
Check warning on line 3 in snippets/pixmap_table/brief.md
|
||
|
|
||
| - **Glyph storage** - Contains the pixmap images for font characters | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # constant_bits_per_pixel | ||
|
|
||
| Write the documentation content for constant_bits_per_pixel here. | ||
| The bits per pixel shared by all pixmaps in this table (only 1-8 supported). | ||
|
Check notice on line 1 in snippets/pixmap_table/configurations/brief/constant_bits_per_pixel.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # constant_height | ||
|
|
||
| Write the documentation content for constant_height here. | ||
| The height in pixels shared by all pixmaps in this table. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # constant_width | ||
|
|
||
| Write the documentation content for constant_width here. | ||
| The width in pixels shared by all pixmaps in this table. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `use_constant_bits_per_pixel` is enabled | ||
|
Check notice on line 1 in snippets/pixmap_table/configurations/condition/constant_bits_per_pixel.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `use_constant_height` is enabled. | ||
|
Check notice on line 1 in snippets/pixmap_table/configurations/condition/constant_height.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `use_constant_width` is enabled. | ||
|
Check notice on line 1 in snippets/pixmap_table/configurations/condition/constant_width.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| All pixmaps in this table use the same number of bits to represent a pixel. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Add Both documentation lines use the project’s domain term
🧰 Tools🪛 GitHub Actions: vale / 1_vale.txt[error] 1-1: [Vale.Spelling] Did you really mean 'pixmaps'? 🪛 GitHub Actions: vale / vale[error] 1-1: Vale.Spelling: Did you really mean 'pixmaps'? 🪛 GitHub Check: vale[failure] 1-1: [vale] snippets/pixmap_table/configurations/flag/use_constant_bits_per_pixel.md#L1 📍 Affects 2 files
🤖 Prompt for AI AgentsSources: Linters/SAST tools, Pipeline failures |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| All pixmaps in this table share the same height. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| All pixmaps in this table share the same width. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # color_tables | ||
|
|
||
| Write the documentation content for color_tables here. | ||
| Length byte followed by that many Color Table indices supplying the palette that pixel values index into. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| If `link_color_tables` is enabled. | ||
|
Check notice on line 1 in snippets/pixmap_table/links/condition/color_tables.md
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This table links to one or more Color Tables for palette mapping |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| # bits_per_pixel | ||
|
|
||
| Write the documentation content for bits_per_pixel here. | ||
| Bits used to represent each pixel of this pixmap (only 1-8 supported). | ||
|
Check notice on line 1 in snippets/pixmap_table/records/brief/bits_per_pixel.md
|
||
Uh oh!
There was an error while loading. Please reload this page.