Conversation
… the core-based release
bendersej
force-pushed
the
P040-wp-plugin-improvements
branch
from
September 25, 2026 14:37
054c122 to
503a080
Compare
…, and uninstall cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The WordPress plugin's settings page showed a single text field. Admins could not tell which PDFs the plugin takes over, could not try it on one page before going live, and did not know where filled PDFs go.
Changes
uninstall.phpremoves every option the plugin stores@simplepdf/web-embed-pdf1.8.4 bundle; its version is now one constant used for cache busting. Verified in WordPress Playground, andphp -lis clean on PHP 5.6.Notes
@simplepdf/web-embed-pdfrelease (rebuilt on@simplepdf/embed, with PDF links detected in any extension case, query or fragment): the plugin pins it before it is published.