Skip to content

Address build issues on windows.#95

Merged
zivy merged 2 commits into
SimpleITK:mainfrom
zivy:resolveBuildIssues
May 10, 2026
Merged

Address build issues on windows.#95
zivy merged 2 commits into
SimpleITK:mainfrom
zivy:resolveBuildIssues

Conversation

@zivy
Copy link
Copy Markdown
Member

@zivy zivy commented May 7, 2026

Add cmake flags to address build issues on windows and modify the post build steps in the configure.win so that they depend on a successful build.

Comment thread configure.win Outdated
@zivy zivy force-pushed the resolveBuildIssues branch 5 times, most recently from 537610d to 143ba3c Compare May 8, 2026 19:35
Modify the post build steps in the configure.win
so that they depend on a successful build. Only
support R4.4.x and above. On Windows R4.3.x does
not build successfuly with the corresponding rtools.
@zivy zivy force-pushed the resolveBuildIssues branch 2 times, most recently from b18d1ac to 9b427ac Compare May 9, 2026 17:04
@zivy zivy mentioned this pull request May 9, 2026
cmake --version
if [[ "$RUNNER_OS" == "Windows" ]]; then
g++ --version
ls -d /c/rtools* 2>/dev/null || echo "No rtools found in /c/"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider: `... | ( echo "::error No rtools found in /c/") && exit 1)

@zivy zivy force-pushed the resolveBuildIssues branch from 9b427ac to 7d52b5c Compare May 10, 2026 13:09
Check that the SimpleITK package was
successfully installed.
@zivy zivy force-pushed the resolveBuildIssues branch from 7d52b5c to 21cd52e Compare May 10, 2026 16:19
@zivy zivy merged commit 1f63bc8 into SimpleITK:main May 10, 2026
9 checks passed
@zivy zivy deleted the resolveBuildIssues branch May 10, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants