feat(executors): add Aider adapter behind the Executor protocol - #96
Merged
Conversation
Closes #53. Ports @adity982's implementation from PR #55. That PR could not be rebased: it predates the umbra_core -> signetry_core rename (#90), so every file it touched had moved. The adapter design is theirs — the flag set, deriving the result from the repository diff rather than from Aider's own claim, and redacting the prompt from the replay command. This port updates the package path, the env-var prefix (UMBRA_ -> SIGNETRY_), and adds the safety tests. Registered as `aider`. Fail-closed on two independent conditions: SIGNETRY_ENABLE_AIDER=true AND the CLI actually responding to --version. Commit authority stays with the pipeline: --no-auto-commits and --no-dirty-commits mean Aider edits the working tree but never creates a commit, so the change stays governable by admission. --no-suggest-shell-commands keeps it from proposing shell execution, and --dry-run is used for read-only (reason) runs. model_identity reports model_resolved as "unavailable" rather than back-filling the requested model, because Aider does not echo the provider model it resolved — claiming otherwise would put an unverified value on a receipt. 13 tests: fail-closed gating (flag missing, CLI missing), protocol + registry membership, diff capture, the safety-flag contract (asserting no commit is created in a real temp repo), --dry-run on read_only, prompt redaction, honest "unavailable" on a failed run, the disabled result, model pass-through, and that registration does not let aider be auto-selected ahead of a configured preference. Also updates the pre-existing registry test, which pinned the exact executor set, and tidies a line wrap left in README by the Kotlin change.
Signetry Reviewer — 🟡 Needs human reviewA human should decide — the required check is pending. Deterministic gates (the authority)
FindingsNo issues found by the deterministic scanners. MergeA human should review and merge.
|
This was referenced Aug 18, 2026
bkd-dotcom
added a commit
that referenced
this pull request
Aug 18, 2026
@adity982 never signed the CLA. Verified against the authoritative store — signatures/cla.json on the cla-signatures branch lists exactly one signed contributor (AdvaitVarhade, from #73). The two "I have read the CLA" strings on #55 are the bot's own instruction text and a quote of it in a maintainer comment, not a signature. CONTRIBUTORS.md states that the people listed are acknowledged "for contributions accepted under the Contributor License Agreement", so an unsigned contribution does not belong in that list. NOTE — this leaves an open provenance question, not resolved here. The Aider adapter merged in #96 is a port of their #55, and aider.py still records that derivation in its module docstring. Without a signed CLA the copyright assignment never happened, so the repo now contains code derived from an unassigned contribution. That needs a decision (reimplement from the sibling adapters, or obtain a signature) — flagged rather than settled by this commit.
bkd-dotcom
added a commit
that referenced
this pull request
Aug 18, 2026
@adity982 never signed the CLA. Verified against the authoritative store — signatures/cla.json on the cla-signatures branch lists exactly one signed contributor (AdvaitVarhade, from #73). The two "I have read the CLA" strings on #55 are the bot's own instruction text and a quote of it in a maintainer comment, not a signature. CONTRIBUTORS.md states that the people listed are acknowledged "for contributions accepted under the Contributor License Agreement", so an unsigned contribution does not belong in that list. NOTE — this leaves an open provenance question, not resolved here. The Aider adapter merged in #96 is a port of their #55, and aider.py still records that derivation in its module docstring. Without a signed CLA the copyright assignment never happened, so the repo now contains code derived from an unassigned contribution. That needs a decision (reimplement from the sibling adapters, or obtain a signature) — flagged rather than settled by this commit. Co-authored-by: Binay <bkd-dotcom@users.noreply.github.com>
This was referenced Aug 18, 2026
bkd-dotcom
added a commit
that referenced
this pull request
Aug 18, 2026
Resolves the provenance question flagged in #99. The version merged in #96 was a port of an unsigned contribution (#55). Without a signed CLA the copyright assignment never happened, so keeping derived code — especially after removing the attribution — was the least defensible combination. This rewrites the adapter from the sibling adapters (codex.py / claude_code.py, both owner-authored) so nothing in the tree derives from an unassigned contribution, and drops the attribution from the module docstring and the v0.7.0 changelog entry. Behaviour is unchanged: all 33 executor tests written against the previous implementation pass without modification, because they assert behaviour rather than structure. Two things the rewrite adds, both from house patterns the port lacked: * --model is validated before use, like the Codex adapter's -m value, so a caller-supplied string cannot smuggle shell metacharacters or extra arguments into the command. The first character must be alphanumeric — my own test caught that a naive character class accepts "--dangerously-x", since "-" is legal inside a model name, and an argument parser may read a leading dash as a new option rather than as --model's value. * The withheld-authority flags are a named constant, so removing one shows up in review instead of disappearing into the command construction. A test asserts the set, not just individual flags. Also logs a non-zero exit like claude_code.py does, which the port did not. Co-authored-by: Binay <bkd-dotcom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53. Ports @adity982's work from #55, with credit in
CONTRIBUTORS.md.Why a port instead of a rebase
#55 could not be rebased. It predates the
umbra_core→signetry_corerename (#90), so every file it touched had moved —umbra_core/executors/aider.py,umbra_core/registry.py,umbra_core/cli.py. Git would have seen the whole package as deleted-and-re-added.The adapter design is @adity982's and is preserved as written:
--no-auto-commits,--no-dirty-commits,--no-suggest-shell-commands,--yes-always,--dry-runfor read-only)model_resolvedasunavailablerather than back-filling the requestWhat this port changes: package path, env prefix (
UMBRA_ENABLE_AIDER→SIGNETRY_ENABLE_AIDER,UMBRA_AIDER_MODEL→SIGNETRY_AIDER_MODEL), and the test suite.Security model
SIGNETRY_ENABLE_AIDER=trueand the CLI must answer--version— two independent conditions--no-auto-commits+--no-dirty-commits— edits the working tree, never commits, so admission still governs the change--no-suggest-shell-commands--dry-runonread_only=Truecommandexecutor="unavailable", never a green runOn
model_identity: Aider does not echo the provider model it resolved, somodel_resolvedis"unavailable". Back-filling it from the request would put an unverified value on a signed receipt — the one thing this codebase's honesty rule forbids.Verification
275 tests pass,
ruffclean. 13 new tests:OSError)--dry-runpresent onread_only=Trueexecutor == "unavailable"on a failed runtests_passed is None)model_resolved == "unavailable"aiderbe auto-selected ahead of a configured preferenceTwo incidental changes:
test_registry_lists_and_resolvespinned the exact executor set so it neededaideradded, andFakeRunnerlearned to simulate anaider --messageedit. Also tidied a line wrap I left in the README during the Kotlin change.@adity982 — thank you for this, and sorry it sat. The rename made your branch unrebasable through no fault of yours, so I ported it rather than asking you to redo the work. If you'd prefer to carry it yourself instead, say so and I'll close this in favour of a fresh branch from you.