A failed weekly self-scan has to be visible - #109
Merged
Conversation
#106 fixed why the weekly governed self-scan was failing. This fixes why nobody knew — which is the more interesting half. The scan failed on 2026-08-17, 2026-08-24 and 2026-08-31, three consecutive Mondays, and was only discovered because a human went looking at the run list. A scheduled job that fails silently is indistinguishable from one that never ran, and treating an absent signal as a passing one is exactly the mistake this engine exists to catch. It should not have been our own weekly job doing it. A failing scheduled run now files a report: - Only for `schedule`. A failed workflow_dispatch is already in front of the person who clicked it; filing an issue at them would be noise, and noise is how the first three failures got ignored. - One issue, reused. A fresh issue every Monday would bury the signal it exists to raise, so an already-open report gets a comment instead. - The label is created first, because `gh issue create --label` fails outright on a label that does not exist. - `issues: write` is scoped to this job alone. It gets nothing else — notably not the contents/pull-requests write the scan job holds. The report states plainly that no fix PRs were opened and nothing was merged, so reading it cannot leave anyone unsure whether a half-finished change landed.
Signetry Reviewer — 🟣 Escalate to a designated reviewerEscalate to a designated reviewer — this PR touches security-sensitive surface (.github/workflows/signetry-autofix.yml). No blocking issue was found automatically, but a human owner should sign off. Deterministic gates (the authority)
Findings (1, 0 blocking)
Sensitive surfaceThis PR changes security-sensitive paths that warrant a designated reviewer:
MergeA designated reviewer / code owner should sign off before merge (sensitive surface).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#106fixed why the weekly governed self-scan was failing. This fixes why nobody knew — the more interesting half.The scan failed on 2026-08-17, 2026-08-24 and 2026-08-31 — three consecutive Mondays — and was only discovered because a human went looking at the run list.
A scheduled job that fails silently is indistinguishable from one that never ran. Treating an absent signal as a passing one is precisely the mistake this engine exists to catch, and it should not have been our own weekly job doing it.
What changes
A
notifyjob, 50 added lines, nothing removed. A failing scheduled run files a report.scheduleonlyworkflow_dispatchis already in front of the person who clicked it. Filing an issue at them is noise — and noise is how the first three failures got ignored.gh issue create --labelfails outright on a label that doesn't exist.issues: write, job-scopedcontents/pull-requestswrite the scan job holds.The report says plainly that no fix PRs were opened and nothing was merged, so reading it can't leave anyone wondering whether a half-finished change landed.
Verification
The fix in #106 is already proven, not just merged — a
workflow_dispatchon14d2affran green through all seven steps includingInstall Signetry, the step that was failing, and the scan and PR steps after it. The next scheduled run (Mon 07 Sep) will be the first scheduled green one.This PR cannot be verified the same way, because it only runs when the scan fails.
notifyis unreachable on a green run by construction. What is checked here is that the YAML parses and the job wiring is right:needs: autofix,if: failure() && github.event_name == 'schedule',permissions: {issues: write}.