chore(ci): bump signetry-reviewer pin to v0.2.0 - #101
Merged
Conversation
Picks up the fix for CI rules firing on YAML comments — this repo's own #92 was returned a Block verdict for two comment lines explaining why it deliberately avoids pull_request_target, which is what surfaced that bug. Also brings in the new supply.dependency_skew check (lockfile changed without its manifest), advisory and MEDIUM so it withholds auto-merge without rejecting Dependabot refreshes.
Signetry Reviewer — 🟣 Escalate to a designated reviewerEscalate to a designated reviewer — this PR touches security-sensitive surface (.github/workflows/reviewer.yml). No blocking issue was found automatically, but a human owner should sign off. Deterministic gates (the authority)
Findings (1, 0 blocking)
Sensitive surfaceThis PR changes security-sensitive paths that warrant a designated reviewer:
MergeA designated reviewer / code owner should sign off before merge (sensitive surface).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core still pinned
signetry-reviewer@v0.1.2, so the reviewer fixes merged today were inert here.v0.2.0 brings:
pull_request_target, which is exactly how that bug was foundci.pull_request_targetnow matching the real trigger in all four YAML formssupply.dependency_skewcheck (lockfile changed without its manifest) — advisory and MEDIUM, so it withholds auto-merge without rejecting Dependabot refreshesdeser.introduced(insecure deserialization in a diff), also advisoryactionlintclean. The same bump is included in the 9 rollout PRs for the other repos.