Skip to content

feat: tooltips and the Crafters tab show offline guild crafters, item tooltips show how many guildies want an item, and the Guild tab shows item level from the site - #12

Merged
JacobCoffee merged 4 commits into
mainfrom
feat/offline-crafters-ux
Nov 11, 2026
Merged

JacobCoffee merged 4 commits into
mainfrom
feat/offline-crafters-ux

Conversation

@JacobCoffee

Copy link
Copy Markdown
Collaborator

Summary

Implements the addon side of SQI1's additive contract so members and gear-readiness info show up for guildies who are offline or have never run the addon, ahead of raids opening Dec 9:

  • Item tooltips' "Crafted by" line now also lists crafters from the site's on-demand import (SideQuestDB.onDemand.crafters + recipe_names), deduplicated against live Directory.WhoCrafts hits and matched by exact recipe name.
  • Item tooltips show a "Wanted by N guildies" line under the Auction house line when GameImportPrice.wanted > 0 (singular "guildie" for exactly one).
  • Crafters > Professions now folds in on-demand crafters (skill + profession), marked offline like the Search tab, deduped against the live directory by character+profession. Cooldowns stay live-only (the import has none).
  • Guild tab member detail shows ilvl from GameImportCharacter.item_level when the live directory hasn't scanned that character's gear; a live scan always wins.

All four fields/behaviors are additive: an import predating them (or missing them) leaves the addon working exactly as before, with no error.

Commits

  • feat: item tooltips show guild crafters even when they're offline
  • feat: item tooltips show how many guildies want an item on their wishlist
  • feat: Crafters > Professions lists guild members from the site even when they're offline
  • feat: Guild tab shows item level from the site import when a member hasn't logged in

Gate (all pass)

  • luajit tests/run_tests.lua — 217 passed, 0 failed
  • luacheck SideQuest tests — 0 warnings / 0 errors in 64 files
  • uv run --directory uploader pytest — 17 passed

Notes for reviewers

  • Depends on the website adding GameImportCharacter.item_level: int | None = None and GameImportPrice.wanted: int = 0 (SQI1, additive) — tracked separately; the addon treats both as optional already.
  • README updated for the Crafters tab, Guild tab detail panel, item tooltip and "What the addon shares" sections.

@JacobCoffee JacobCoffee changed the title Offline crafters, item level and wishlist counts from the site import feat: tooltips and the Crafters tab show offline guild crafters, item tooltips show how many guildies want an item, and the Guild tab shows item level from the site Nov 11, 2026
@JacobCoffee
JacobCoffee merged commit eb4e6dd into main Nov 11, 2026
7 checks passed
@JacobCoffee
JacobCoffee deleted the feat/offline-crafters-ux branch November 11, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant