Repository navigation
feat: tooltips and the Crafters tab show offline guild crafters, item tooltips show how many guildies want an item, and the Guild tab shows item level from the site - #12
Merged
Conversation
…hen they're offline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the addon side of SQI1's additive contract so members and gear-readiness info show up for guildies who are offline or have never run the addon, ahead of raids opening Dec 9:
SideQuestDB.onDemand.crafters+recipe_names), deduplicated against liveDirectory.WhoCraftshits and matched by exact recipe name.GameImportPrice.wanted > 0(singular "guildie" for exactly one).ilvlfromGameImportCharacter.item_levelwhen the live directory hasn't scanned that character's gear; a live scan always wins.All four fields/behaviors are additive: an import predating them (or missing them) leaves the addon working exactly as before, with no error.
Commits
feat: item tooltips show guild crafters even when they're offlinefeat: item tooltips show how many guildies want an item on their wishlistfeat: Crafters > Professions lists guild members from the site even when they're offlinefeat: Guild tab shows item level from the site import when a member hasn't logged inGate (all pass)
luajit tests/run_tests.lua— 217 passed, 0 failedluacheck SideQuest tests— 0 warnings / 0 errors in 64 filesuv run --directory uploader pytest— 17 passedNotes for reviewers
GameImportCharacter.item_level: int | None = NoneandGameImportPrice.wanted: int = 0(SQI1, additive) — tracked separately; the addon treats both as optional already.