Bugfix/uds#60
Conversation
dharabor
left a comment
dharabor
left a comment
There was a problem hiding this comment.
Mostly OK, but missing code comments
| } | ||
| }; | ||
|
|
||
| // Keep for backward compatibility. |
There was a problem hiding this comment.
There's not much point to backwards compatibility at this point. The only affected project is warthog-jps, which we maintain. Might as well fix both.
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| #include "search_metrics.h" | |||
There was a problem hiding this comment.
No header, no description of what is being implemented.
| value, std::forward<TemplateFunc>(tfunc)); | ||
| } | ||
|
|
||
| template<typename T, typename T2> |
There was a problem hiding this comment.
Not clear what we're doing here. please add some comments
| return true; | ||
| } | ||
|
|
||
| struct uds_default_traits |
There was a problem hiding this comment.
No description of what the traits do?
|
|
||
| template<typename Traits> | ||
| inline consteval admissibility_criteria | ||
| uds_trait_ac() noexcept |
There was a problem hiding this comment.
Missing a description. what does this do? (please add comments similar to reopen policy)
| } | ||
|
|
||
| template<typename Traits> | ||
| inline consteval feasibility_criteria |
There was a problem hiding this comment.
Please add comments to describe what this does
|
|
||
| template<typename Traits> | ||
| inline consteval reopen_policy | ||
| uds_trait_rp() noexcept |
There was a problem hiding this comment.
Please add comments to describe what this does
2 participants
No description provided.