Add --ignore-errors option to spoom srb tc#879
Open
Morriar wants to merge 1 commit into
Open
Conversation
Morriar
force-pushed
the
at-tc-ignore-errors
branch
5 times, most recently
from
e9a6a1d to
2860bfe
Compare
Allow ignoring known errors by matching error_code:file:line from an ignore file (default: sorbet/ignored_errors.cfg). Ignored errors are hidden from output, shown as a count in the summary, and don't cause a non-zero exit code.
Morriar
force-pushed
the
at-tc-ignore-errors
branch
from
2860bfe to
95dfd76
Compare
KaanOzkan
reviewed
May 20, 2026
| stale = ignored_errors - matched | ||
| unless stale.empty? | ||
| stale.each do |entry| | ||
| say_error("Stale entry in ignore file: #{entry[0]}:#{entry[1]}:#{entry[2]}", status: nil) |
Contributor
There was a problem hiding this comment.
Looks like we exit early if result.status above. So stale information is only printed if there are errors, is this intentional? I feel like we should always try to keep the list up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ignore-errorsoption tospoom srb tcto ignore known errors by matchingerror_code:file:linefrom an ignore filesorbet/ignored_errors.cfg(auto-detected when present)Errors: 2 ignored, 7 total), and don't cause a non-zero exit code#comments and blank lines in the ignore fileIgnore file format
Test plan
X ignored, Y total--ignore-errors=path