Add example for defining new agent provider#784
Open
dersam wants to merge 1 commit into02-12-move_agent_providers_into_shared_registryfrom
Open
Add example for defining new agent provider#784dersam wants to merge 1 commit into02-12-move_agent_providers_into_shared_registryfrom
dersam wants to merge 1 commit into02-12-move_agent_providers_into_shared_registryfrom
Conversation
dersam
requested review from
juniper-shopify,
mathiusj and
nfgrep
as code owners
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dersam
force-pushed
the
02-12-add_example_for_defining_new_agent_provider
branch
from
373be46 to
df57af6
Compare
This is the most minimal possible agent. This one always responds with the same thing and always succeeds. This should make it easier to understand how to implement providers, as the Claude version is quite complex. Also we decided we don't care about duplicated agent responses in Claude and removed some special casing.
dersam
force-pushed
the
02-12-add_example_for_defining_new_agent_provider
branch
from
df57af6 to
530dc39
Compare
This was referenced Feb 13, 2026
nfgrep
approved these changes
Feb 13, 2026
juniper-shopify
requested changes
Feb 13, 2026
Comment on lines
-151
to
-153
| formatted_message = message.format(@context) | ||
| puts formatted_message if formatted_message.present? && @show_progress | ||
|
|
Contributor
There was a problem hiding this comment.
where does progress get displayed now if we remove these lines?
|
|
||
| if from | ||
| # Load gem - no special requires, gem must handle everything | ||
| require from |
Contributor
There was a problem hiding this comment.
there's already a require from if from on line 101
Comment on lines
+109
to
+110
| loadables.each do |cog_name| | ||
| require @workflow_path.realdirpath.dirname.join("cogs/#{cog_name}").to_s |
Contributor
There was a problem hiding this comment.
shouldn't this be something more generic that cog_name here?
| require path.to_s if from.nil? | ||
| loadables.each do |name| | ||
| class_name_string = name.camelize | ||
| raise InvalidCogReference, "#{name} class not found" unless Object.const_defined?(class_name_string) |
Contributor
There was a problem hiding this comment.
why do we need this raise?
and shouldn't InvalidCogReference be completely replaced InvalidLoadableReference now?
Comment on lines
+39
to
+43
| attr_accessor :timeout | ||
|
|
||
| def initialize | ||
| @timeout = 30 | ||
| end |
Contributor
There was a problem hiding this comment.
This won't work with config merging. With our architecture, config values must be stored in the @values hash.
Suggested change
| attr_accessor :timeout | |
| def initialize | |
| @timeout = 30 | |
| end | |
| def timeout(seconds) | |
| @values[:timeout] = seconds | |
| end | |
| # by convention, we use `valid_<attibute>` method as accessors used by the cog, to distinguish them from setters used in the workflow definition | |
| def valid_timeout | |
| @values.fetch(:timeout, 30) | |
| end |
Comment on lines
+266
to
+267
| raise "City is required" if city.nil? || city.empty? | ||
| true |
Contributor
There was a problem hiding this comment.
Suggested change
| raise "City is required" if city.nil? || city.empty? | |
| true | |
| raise "City is required" if city.blank? |
| end | ||
|
|
||
| execute do | ||
| weather do |
Contributor
There was a problem hiding this comment.
Suggested change
| weather do | |
| weather(:my_weather) do |
Comment on lines
+313
to
+316
| <<~PROMPT | ||
| The weather in #{weather!.city} is #{weather!.temperature}°F and #{weather!.conditions}. | ||
| Should I bring an umbrella? | ||
| PROMPT |
Contributor
There was a problem hiding this comment.
This is not the correct way to access cog output
Suggested change
| <<~PROMPT | |
| The weather in #{weather!.city} is #{weather!.temperature}°F and #{weather!.conditions}. | |
| Should I bring an umbrella? | |
| PROMPT | |
| city, temperature, conditions = weather!(:my_weather).values_at(:city, :temperature, :conditions) | |
| <<~PROMPT | |
| The weather in #{city} is #{temperature}°F and #{conditions}. | |
| Should I bring an umbrella? | |
| PROMPT |
Comment on lines
+330
to
+332
| def validate! | ||
| true | ||
| end |
Contributor
There was a problem hiding this comment.
Suggested change
| def validate! | |
| true | |
| end | |
| def validate! | |
| end |
| end | ||
|
|
||
| def execute(input) | ||
| puts "I'm a namespaced cog!" |
Contributor
There was a problem hiding this comment.
Suggested change
| puts "I'm a namespaced cog!" | |
| puts "I'm a namespaced cog!" | |
| Cog::Output.new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most minimal possible agent. This one always responds with
the same thing and always succeeds. This should make it easier to
understand how to implement providers, as the Claude version is quite
complex.
Also we decided we don't care about duplicated agent responses in Claude
and removed some special casing.